This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Encrypt Event Check-in data before submit (EXPOSUREAPP-8685) #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtwalli
commented
Aug 2, 2021
•
edited
edited
- Feature branch
* implement CheckInCryptography * add tests * code refactoring * one more test * code refactoring
* Pass encrypted checkin * Revert * Provide encrypted checkins * Update CheckInsTransformerTest.kt * Update SubmissionServerTest.kt * Adjust unit tests * Update CheckInsTransformer.kt * Fix test
This reverts commit e01cf03.
* Rename and add encrypted API version 2 * Move to right package * Lint * Provide encryption mode from Task controller * Lint * Derive protected warnings * Lint * Simple check * Derive TraceWarning from CheckInReports * lint * Fix tests * Lint * Create TraceWarningServerTest.kt * Create CheckInWarningMatcherKtTest.kt * Create CheckInWarningMatcherTest2.kt * Log * Small fixes * Update CheckInWarningMatcherTest2.kt * Use encrypted CheckIns size * More unit tests for deriving
Kudos, SonarCloud Quality Gate passed! |
BMItr
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to complain 👌
jurajkusnier
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
author merge
PR to be merged by author
maintainers
Tag pull requests created by maintainers
prio
PRs to review first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.