Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

ICAO name for certificates (EXPOSUREAPP-8686) #3868

Merged
merged 7 commits into from Aug 4, 2021
Merged

ICAO name for certificates (EXPOSUREAPP-8686) #3868

merged 7 commits into from Aug 4, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

Introducing ICAO (standardized) name in certificates (test, vaccination and recovery).

Screenshot 2021-08-03 at 15 58 18

How to test:

  1. generate test, vaccination and recovery QR codes
  2. go to certificates details

@AlexanderAlferov AlexanderAlferov added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Aug 3, 2021
@AlexanderAlferov AlexanderAlferov added this to the 2.8.0 milestone Aug 3, 2021
@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review August 3, 2021 13:23
@AlexanderAlferov AlexanderAlferov requested a review from a team August 3, 2021 13:23
@dsarkar dsarkar mentioned this pull request Aug 3, 2021
Closed
@mtwalli mtwalli self-assigned this Aug 3, 2021
@jurajkusnier jurajkusnier self-assigned this Aug 3, 2021
jurajkusnier
jurajkusnier reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also screenshots

mtwalli
mtwalli approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Screenshot 2021-08-04 at 14 44 45

jurajkusnier
jurajkusnier approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
47.4% 47.4% Duplication

@mtwalli mtwalli merged commit 7793058 into release/2.8.x Aug 4, 2021
@mtwalli mtwalli deleted the feature/8686-icao-name-for-certificates branch August 4, 2021 13:25
SamuraiKek pushed a commit that referenced this pull request Aug 11, 2021
@AlexanderAlferov @mtwalli
@jurajkusnier @SamuraiKek
ICAO name for certificates (EXPOSUREAPP-8686) (#3868)
870df6c 
* ICAO name for certificates

* New fullNameStandardizedFormatted interface field + screenshots

* Test fix

* First name check logic

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@jurajkusnier jurajkusnier

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexanderAlferov @jurajkusnier @mtwalli