Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix CWA crashes and cannot be restarted after the attempt to receive a faked-vaccination certificate (EXPOSUREAPP-8876) #3886

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Fix CWA crashes and cannot be restarted after the attempt to receive a faked-vaccination certificate (EXPOSUREAPP-8876) #3886

merged 3 commits into from
Aug 6, 2021

Conversation

jurajkusnier
Copy link
Contributor

  • DCC-Server response with fake cert couldn't crash the CWA
  • correct RAT and PCR tests should work as usual

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Aug 6, 2021
@jurajkusnier jurajkusnier added this to the 2.7.0 milestone Aug 6, 2021
@jurajkusnier jurajkusnier requested a review from a team August 6, 2021 09:06
@ralfgehrer ralfgehrer self-assigned this Aug 6, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli self-assigned this Aug 6, 2021
mtwalli
mtwalli approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, Tested PCR and RAT certificates and pending cases still work as before

@jurajkusnier jurajkusnier merged commit 136a75b into release/2.7.x Aug 6, 2021
@jurajkusnier jurajkusnier deleted the fix/8876-fake_cert_crash_app branch August 6, 2021 10:15
mtwalli added a commit that referenced this pull request Aug 10, 2021
@mtwalli @NataliaLemmerth
@ralfgehrer @service-tip-git @jurajkusnier @AlexanderAlferov @Kolpa @kolyaopahle @marcauberer
2.7 into 2.8 (DEV) (#3900)
7f2f8c0 
* UA Bugfix(EXPOSUREAPP-8552) (#3880)

* UA Bugfix(EXPOSUREAPP-8552) (#3879)

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>

* Fix issue with text placeholders (EXPOSUREAPP-8870) #3882

* Fix issue with text placeholders (EXPOSUREAPP-8870)

* Please lint

* Please ktlint

* Please lint

* [INTERNAL] Translation delivery: commit by LX Lab (#3885)

Change-Id: Ia554c33eb50aff893fe390f0c69bcf4d5527b585

* Fix CWA crashes and cannot be restarted after the attempt to receive a faked-vaccination certificate (EXPOSUREAPP-8876) (#3886)

* handle creating TestCertificateQRCode

* fix detekt

* Fix: correct dcc state check worker (EXPOSUREAPP-8849) (#3889)

* Correct worker

* Lint fix

* Spike: Import QR Code via Image (EXPOSUREAPP-8358) (#3837)

* initial testing button and document intent for qr code from file scanning

* Refactored Image Resolver,
Added PDF Resolver,
Parser still cannot find qr codes in images

* pdf bitmap is now scaled accordingly

* Read  Qr-Code content

* Lint

* Scale and try

* Image and Pdf resolvers now yield increasingly larger images to allow for ram conservation and faster parsing speeds

* Linting

* Moved qr code file scanning to test fragment

* Removed lingering code from DccQrCodeScanViewModel and fragment_scan_qr_code

Co-authored-by: Kolya Opahle <k.opahle@sap.com>
Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>

* update default dsc list (#3897)

* Version Bump to 2.7.0.3 (#3898)

Co-authored-by: Natalia Lemmerth <83214960+NataliaLemmerth@users.noreply.github.com>
Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
Co-authored-by: SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Co-authored-by: AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com>
Co-authored-by: Kolpa <kolyaopahle@gmail.com>
Co-authored-by: Kolya Opahle <k.opahle@sap.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
mtwalli added a commit that referenced this pull request Aug 11, 2021
@mtwalli @NataliaLemmerth
@ralfgehrer @service-tip-git @jurajkusnier @AlexanderAlferov @Kolpa @kolyaopahle @marcauberer @Corona-Warn-App-Technical-User @BMItr @SamuraiKek
Merge 2.7 into 2.8 (DEV) (#3911)
a0ec5a2 
* UA Bugfix(EXPOSUREAPP-8552) (#3880)

* UA Bugfix(EXPOSUREAPP-8552) (#3879)

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>

* Fix issue with text placeholders (EXPOSUREAPP-8870) #3882

* Fix issue with text placeholders (EXPOSUREAPP-8870)

* Please lint

* Please ktlint

* Please lint

* [INTERNAL] Translation delivery: commit by LX Lab (#3885)

Change-Id: Ia554c33eb50aff893fe390f0c69bcf4d5527b585

* Fix CWA crashes and cannot be restarted after the attempt to receive a faked-vaccination certificate (EXPOSUREAPP-8876) (#3886)

* handle creating TestCertificateQRCode

* fix detekt

* Fix: correct dcc state check worker (EXPOSUREAPP-8849) (#3889)

* Correct worker

* Lint fix

* Spike: Import QR Code via Image (EXPOSUREAPP-8358) (#3837)

* initial testing button and document intent for qr code from file scanning

* Refactored Image Resolver,
Added PDF Resolver,
Parser still cannot find qr codes in images

* pdf bitmap is now scaled accordingly

* Read  Qr-Code content

* Lint

* Scale and try

* Image and Pdf resolvers now yield increasingly larger images to allow for ram conservation and faster parsing speeds

* Linting

* Moved qr code file scanning to test fragment

* Removed lingering code from DccQrCodeScanViewModel and fragment_scan_qr_code

Co-authored-by: Kolya Opahle <k.opahle@sap.com>
Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>

* update default dsc list (#3897)

* Version Bump to 2.7.0.3 (#3898)

* Bump to next Version: 2.7.0.4 (#3899)

* Improve logs for 8113 (DEV) (#3901)

* Add more logs statements

* UI logs

* More logs

* Certificate expired adjustments (EXPOSUREAPP-8837) (#3902)

* Refresh cer state in on start

* source clean

* Version Bump to 2.7.1.0  (DEV) #3907

* Remove UI states from test certs (EXPOSUREAPP-8885, 8886) #3908

* Excluded test certificates from expiry status.

* Lint and detekt.

* Removed repeating line.

* Handle test certificate state

* Comment

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>

* Set patch =0

* Fix instrumentation test (DEV) (#3912)

* Fix instrumentation test.

* More fixes.

Co-authored-by: Natalia Lemmerth <83214960+NataliaLemmerth@users.noreply.github.com>
Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
Co-authored-by: SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Co-authored-by: AlexanderAlferov <64849422+AlexanderAlferov@users.noreply.github.com>
Co-authored-by: Kolpa <kolyaopahle@gmail.com>
Co-authored-by: Kolya Opahle <k.opahle@sap.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
Co-authored-by: CWA Technical User <67319337+Corona-Warn-App-Technical-User@users.noreply.github.com>
Co-authored-by: BMItr <Berndus@gmx.de>
Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@ralfgehrer ralfgehrer

@mtwalli mtwalli

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jurajkusnier @ralfgehrer @mtwalli