Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Automatically refresh certificates after DSC list update (EXPOSUREAPP-8886) #3935

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Automatically refresh certificates after DSC list update (EXPOSUREAPP-8886) #3935

merged 3 commits into from
Aug 18, 2021

Conversation

jurajkusnier
Copy link
Contributor

Testing

  • install CWA 2.6
  • generate and scan tc, vc, rc
  • update CWA with this branch
  • check if all certificates are still valid
  • you can also play with the Test Menu ( DCC Signature Verification > Refresh / Clear cache )

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Aug 18, 2021
@jurajkusnier jurajkusnier added this to the 2.8.0 milestone Aug 18, 2021
@jurajkusnier jurajkusnier requested a review from a team August 18, 2021 06:04
mtwalli
mtwalli approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, did not check on device

@mtwalli mtwalli self-assigned this Aug 18, 2021
@SamuraiKek SamuraiKek self-assigned this Aug 18, 2021
@SamuraiKek
Copy link
Contributor

Tested on device from 2.6 to this branch with the certificate from the jira ticket but it still shows up invalid for me.

@mtwalli
Copy link
Contributor

mtwalli commented Aug 18, 2021

@SamuraiKek Please double check , I have tested the same scenario on device and it worked

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@axelherbstreith axelherbstreith self-assigned this Aug 18, 2021
@SamuraiKek
Copy link
Contributor

@SamuraiKek Please double check , I have tested the same scenario on device and it worked

Retested again. It was a connection issue with my Samsung. After restarting the phone it worked.

@SamuraiKek SamuraiKek merged commit 80771af into release/2.8.x Aug 18, 2021
@SamuraiKek SamuraiKek deleted the feature/8886-check_certificates_immediately branch August 18, 2021 11:42
jurajkusnier added a commit that referenced this pull request Aug 20, 2021
@jurajkusnier
Automatically refresh certificates after DSC list update (EXPOSUREAPP…
7a5d890 
…-8886) (#3935)

* check all certificates immediately after DscRepository.refresh()

* fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@SamuraiKek SamuraiKek

@mtwalli mtwalli

@axelherbstreith axelherbstreith

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jurajkusnier @SamuraiKek @mtwalli @axelherbstreith