Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Unify scanners (EXPOSUREAPP-9330) #4048

Merged
merged 40 commits into from
Sep 13, 2021
Merged

Unify scanners (EXPOSUREAPP-9330) #4048

merged 40 commits into from
Sep 13, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 10, 2021 •
edited

Changes

  • All QrCode types are of type a QrCode
  • Add CheckIn's QrCode QrCodeExtractor
  • Unify QrCodeVerifier that holds a setOf QrCodeExtractors to find and extract QrCode based on type
  • After extracting QrCode it is handed to its relevant Handler to apply the required steps afterwards
  • Extractor functions are now suspended to suit all cases -> many changes in unit tests to address that
  • New Scanner screen (Not wired yet)
  • Importing PDF, Images is considered in the new Scanner ViewModel

TODO in next tickets

  • Wire Scanner to Results screens
  • Error handling

Note

  • App should function as before , new scanner is not used yet

Testing

  • Test menu -> QR Code Image scanning -> Open Scanner
  • Try importing and scanning ,but not that some qrcodes require subsequent steps in order to display the right result
  • You can verify if result is recognised by the Toast

@mtwalli mtwalli requested a review from a team September 10, 2021 09:11
@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Sep 10, 2021
@mtwalli mtwalli added this to the 2.11.0 milestone Sep 10, 2021
@mtwalli mtwalli marked this pull request as draft September 10, 2021 09:11
@mtwalli mtwalli marked this pull request as ready for review September 10, 2021 17:22
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

27.1% 27.1% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek self-assigned this Sep 13, 2021
@jurajkusnier jurajkusnier self-assigned this Sep 13, 2021
SamuraiKek
SamuraiKek approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code looks fine, although I haven't dived deep into it. Testing on device works nicely. I scanned VC, RC, TC, PCR, RAT and Checkin QR's. Also opened jpg equivalents from the file explorer and managed to scan them.

jurajkusnier
jurajkusnier approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier merged commit 8dfb954 into release/2.11.x Sep 13, 2021
@jurajkusnier jurajkusnier deleted the feature/9330-unify-scaners branch September 13, 2021 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@jurajkusnier jurajkusnier

@SamuraiKek SamuraiKek

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @jurajkusnier @SamuraiKek