Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal AllOver-10Minute Change (EXPOSUREAPP-9236) #4050

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Contact Journal AllOver-10Minute Change (EXPOSUREAPP-9236) #4050

merged 6 commits into from
Sep 14, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Sep 10, 2021 •
edited

This PR addresses Exposureapp-9236.
Change to 10 minute intervalls on every relevant entry inside the Journal.

HowToTest:

  • Open the Contact Journal
  • Create some testentries
  • check the duration picker
  • check the export function

Screenshots:

1-10

2-10

3-10

image (4)

@BMItr BMItr requested review from a team September 10, 2021 11:47
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Sep 10, 2021
@BMItr BMItr added this to the 2.11.0 milestone Sep 10, 2021
@jurajkusnier jurajkusnier self-assigned this Sep 10, 2021
@marcauberer marcauberer self-assigned this Sep 10, 2021
marcauberer
marcauberer previously approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@marcauberer marcauberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcauberer marcauberer added the text change PRs with text changes. label Sep 10, 2021
@jurajkusnier
Copy link
Contributor

jurajkusnier commented Sep 10, 2021 •
edited by BMItr

shouldn't the duration interval be also updated (15 > 10 ) in this PR?
image

yes.
coming...
adjusted.

@BMItr BMItr marked this pull request as draft September 10, 2021 12:15
ChristinaTsigganos
ChristinaTsigganos previously approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@BMItr BMItr added the author merge PR to be merged by author label Sep 10, 2021
@BMItr BMItr marked this pull request as ready for review September 10, 2021 14:40
jurajkusnier
jurajkusnier previously approved these changes Sep 13, 2021
View reviewed changes
@axelherbstreith axelherbstreith self-assigned this Sep 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

51.6% 51.6% Coverage
0.0% 0.0% Duplication

ChristinaTsigganos
ChristinaTsigganos approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@BMItr BMItr merged commit 8565e92 into release/2.11.x Sep 14, 2021
@BMItr BMItr deleted the feature/9236-contact-journal-number-10 branch September 14, 2021 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@mtwalli mtwalli mtwalli approved these changes

@ChristinaTsigganos ChristinaTsigganos ChristinaTsigganos approved these changes

@marcauberer marcauberer marcauberer left review comments

Assignees

@jurajkusnier jurajkusnier

@marcauberer marcauberer

@axelherbstreith axelherbstreith

Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BMItr @jurajkusnier @mtwalli @marcauberer @ChristinaTsigganos @axelherbstreith