Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

UQS error handling (EXPOSUREAPP-9326) #4054

Merged
merged 12 commits into from
Sep 14, 2021
Merged

UQS error handling (EXPOSUREAPP-9326) #4054

merged 12 commits into from
Sep 14, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 13, 2021 •
edited

  • Unify error handing of UQS
  • Add strings of Unsupported qr-codes error message

Ticket

Addresses : https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-9326

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Sep 13, 2021
@mtwalli mtwalli added this to the 2.11.0 milestone Sep 13, 2021
@mtwalli mtwalli requested a review from a team September 13, 2021 12:45
@jurajkusnier jurajkusnier self-assigned this Sep 14, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Sep 14, 2021
@mtwalli mtwalli mentioned this pull request Sep 14, 2021
Merged
jurajkusnier
jurajkusnier previously approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli requested a review from a team September 14, 2021 11:05
@mtwalli mtwalli added the text change PRs with text changes. label Sep 14, 2021
AlexanderAlferov
AlexanderAlferov approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.8% 0.8% Coverage
0.0% 0.0% Duplication

ChristinaTsigganos
ChristinaTsigganos approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@mtwalli mtwalli merged commit 3e15832 into release/2.11.x Sep 14, 2021
@mtwalli mtwalli deleted the feature/9326-error-handling branch September 14, 2021 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@ChristinaTsigganos ChristinaTsigganos ChristinaTsigganos approved these changes

@jurajkusnier jurajkusnier jurajkusnier left review comments

Assignees

@jurajkusnier jurajkusnier

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @jurajkusnier @AlexanderAlferov @ChristinaTsigganos