Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Certificate display switches to expired-view (if expired) after opening the certificate view (EXPOSUREAPP-8837) #4057

Merged
merged 13 commits into from Sep 15, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Sep 13, 2021

This PR addresses Exposureapp-8337.
"Certificate display switches to "expired-view" only after app re-start"

About:
The check whether a certificate has expired or not usually runs every 24hours.
This PR adds a second check which is triggered opening the certificate-overview.

How-to-test:

  • scan a Certificate which will expire in some minutes (can be found in the QR-Example Folder "Special QRs" or CLI Tool-> vc gen --exp 1minute)
  • opening the CertView (MainScreen->BottomBar) will show a list of your certificates.
  • if the certificate is expired it should show up already in the certificate overview screen

Screenshot
image

@BMItr BMItr requested a review from a team September 13, 2021 15:18
@BMItr BMItr added this to the 2.10.0 milestone Sep 13, 2021
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Sep 13, 2021
@mtwalli mtwalli added the prio PRs to review first. label Sep 14, 2021
@mtwalli mtwalli self-assigned this Sep 14, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Sep 14, 2021

@BMItr Is it acceptable that we do multiple validity checks now while the App in foreground ? can you please align with Max?

mtwalli
mtwalli previously approved these changes Sep 14, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Sep 14, 2021
@BMItr BMItr added the author merge PR to be merged by author label Sep 14, 2021
@BMItr
Copy link
Contributor Author

BMItr commented Sep 14, 2021

do not merge yet.
I found an underlaying issue regarding Certificate Checks in general. (under investigation)
update:
The state check happens inside the respective flow of the repos. But the flows are shared flows and they cache the data as long as they have subscribers. This explains the flaky behaviour, why it was sometimes working and sometimes not. I fixed this by adding non cached (aka fresh) flows. State check should now work as expected.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mtwalli mtwalli merged commit aec9c24 into release/2.10.x Sep 15, 2021
@mtwalli mtwalli deleted the fix/8837-expired branch September 15, 2021 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants