This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Certificate display switches to expired-view (if expired) after opening the certificate view (EXPOSUREAPP-8837) #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@BMItr Is it acceptable that we do multiple validity checks now while the App in foreground ? can you please align with Max? |
mtwalli
previously approved these changes
Sep 14, 2021
do not merge yet. |
Kudos, SonarCloud Quality Gate passed! |
AlexanderAlferov
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
mtwalli
approved these changes
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
author merge
PR to be merged by author
maintainers
Tag pull requests created by maintainers
prio
PRs to review first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Exposureapp-8337.
"Certificate display switches to "expired-view" only after app re-start"
About:
The check whether a certificate has expired or not usually runs every 24hours.
This PR adds a second check which is triggered opening the certificate-overview.
How-to-test:
Screenshot