Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update FAQ Position (EXPOSUREAPP-9031) #4058

Merged
merged 8 commits into from
Sep 15, 2021

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Sep 14, 2021

Updated the FAQ position in the certificate validation result screen for all states

Passed

image

Failed
image

Open
image

@axelherbstreith axelherbstreith added the maintainers Tag pull requests created by maintainers label Sep 14, 2021
@axelherbstreith axelherbstreith added this to the 2.11.0 milestone Sep 14, 2021
@axelherbstreith axelherbstreith requested a review from a team September 14, 2021 06:43
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very tiny difference in open state screen the statement before the link should end with . not a :
@axelherbstreith FYI

@mtwalli mtwalli self-assigned this Sep 15, 2021
@axelherbstreith axelherbstreith requested a review from a team September 15, 2021 08:39
@jurajkusnier jurajkusnier self-assigned this Sep 15, 2021
@axelherbstreith axelherbstreith added the text change PRs with text changes. label Sep 15, 2021
@axelherbstreith
Copy link
Contributor Author

@mtwalli thanks! String is adapted

Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@axelherbstreith axelherbstreith merged commit 59f119f into release/2.11.x Sep 15, 2021
@axelherbstreith axelherbstreith deleted the feature/9031-new-faq-position branch September 15, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants