Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add visual certificate indicator (EXPOSUREAPP-9200) #4078

Merged
merged 9 commits into from
Sep 20, 2021
Merged

Add visual certificate indicator (EXPOSUREAPP-9200) #4078

merged 9 commits into from
Sep 20, 2021

Conversation

axelherbstreith
Copy link
Contributor

Added visual indicator in form of an error to all certificate cards in the person details screen

Recovery Certificate:

image

Vaccination Certificate

image

Test Certificate

image

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Sep 15, 2021
@axelherbstreith axelherbstreith added this to the 2.11.0 milestone Sep 15, 2021
@axelherbstreith axelherbstreith requested review from a team September 15, 2021 13:15
@marcauberer
Copy link
Member

@axelherbstreith doesn't the icon already exist in ic_forward? I think you could use this instead of creating a new icon resource.

NataliaLemmerth
NataliaLemmerth previously approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@jurajkusnier jurajkusnier self-assigned this Sep 16, 2021
@jurajkusnier
Copy link
Contributor

Looks good, just Impfzertifikat is a bit off.
Also, check the layout with the increased font size.
And could you try android:hyphenationFrequency="normal" instead of hardcoding hyphen into the text?

image

@SamuraiKek SamuraiKek self-assigned this Sep 20, 2021
mtwalli
mtwalli approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli assigned mtwalli and unassigned SamuraiKek Sep 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit ab35535 into release/2.11.x Sep 20, 2021
@mtwalli mtwalli deleted the feature/9200-visual-certificate-indicator branch September 20, 2021 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcauberer marcauberer marcauberer left review comments

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@mtwalli mtwalli mtwalli approved these changes

@NataliaLemmerth NataliaLemmerth NataliaLemmerth left review comments

Assignees

@jurajkusnier jurajkusnier

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@axelherbstreith @marcauberer @jurajkusnier @mtwalli @NataliaLemmerth @SamuraiKek