Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Certificates - CovPass Information Adjustments (EXPOSUREAPP-9430) #4087

Merged
merged 37 commits into from
Sep 22, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Sep 17, 2021

Feature Branch for EXPOSUREAPP-9430, containing all subtasks (do not merge yet)

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-9430

Screenshot: (additional Info on top of the QR Code)

image

some smaller style adjustments regarding certificate views: (top text & name)

image

adding the name of the cert owner (Cert Details View):

image

@BMItr BMItr requested review from a team September 17, 2021 17:20
@BMItr BMItr self-assigned this Sep 17, 2021
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Sep 17, 2021
@BMItr BMItr added this to the 2.11.0 milestone Sep 17, 2021
@BMItr BMItr added the author merge PR to be merged by author label Sep 17, 2021
@BMItr BMItr marked this pull request as draft September 17, 2021 17:21
@BMItr BMItr changed the title Certificates - Information Adjustments (EXPOSUREAPP-xxxx) Certificates - Information Adjustments (EXPOSUREAPP-9430) Sep 17, 2021
@BMItr BMItr changed the title Certificates - Information Adjustments (EXPOSUREAPP-9430) Certificates - CovPass Information Adjustments (EXPOSUREAPP-9430) Sep 17, 2021
@BMItr BMItr marked this pull request as ready for review September 21, 2021 16:08
@jurajkusnier jurajkusnier self-assigned this Sep 22, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Sep 22, 2021
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions. And also small part of the text is not visible on my device
image

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.1% 19.1% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit aac1103 into release/2.11.x Sep 22, 2021
@mtwalli mtwalli deleted the feature/9475-9476-qr-note-and-logic branch September 22, 2021 15:41
@MikeMcC399
Copy link
Contributor

@mtwalli
You probably already know that the text display problems mentioned in #4087 (review) by @jurajkusnier are not yet fixed. But just in case this has slipped by ...

The problem is still reproducible in release/2.11.x with the latest commit (8eeb2f7).
Run PersonOverviewFragmentTest on Google Pixel 3a emulator with Android 11 and font size and display size both set to Default.

PersonOverviewFragment_many_persons

Setting font size to largest and display size to larger gives a more extreme view where much more of the text is cut off.

image

@BMItr
Copy link
Contributor Author

BMItr commented Sep 25, 2021

This Problem has already been reported (Exposureapp-9628).
Will be fixed by upcoming PR (branch: fix/9628-overlapping)

@MikeMcC399
Copy link
Contributor

@BMItr
Thanks for the pointer to fix/9628-overlapping. That seems to fix it fine! 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants