Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Polishing / Testing UQS (EXPOSUREAPP-9433) #4099

Merged
merged 23 commits into from
Sep 21, 2021
Merged

Polishing / Testing UQS (EXPOSUREAPP-9433) #4099

merged 23 commits into from
Sep 21, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 20, 2021 •
edited

Addresses: EXPOSUREAPP-9433

Changes

  • Added more unit tests
  • Instrumentation tests for UQS
  • OrganizerWarnQrCodeScannerFragment uses new Result API to request permission instead of deprecated API (To match UQS)
  • Remove individual QrCode validators of Dcc and CoronaTest
  • SubmissionConsentFragment takes CoronaTestQrCode instead of rawString QrCode. all starting points now can provide the qrcode request directly, no need to parse and validate it again

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Sep 20, 2021
@mtwalli mtwalli added this to the 2.11.0 milestone Sep 20, 2021
@mtwalli mtwalli marked this pull request as ready for review September 21, 2021 11:27
@mtwalli mtwalli requested a review from a team September 21, 2021 11:27
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.3% 13.3% Coverage
22.0% 22.0% Duplication

@SamuraiKek SamuraiKek self-assigned this Sep 21, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Sep 21, 2021
AlexanderAlferov
AlexanderAlferov approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

SamuraiKek
SamuraiKek approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtwalli mtwalli merged commit 13e07c2 into release/2.11.x Sep 21, 2021
@mtwalli mtwalli deleted the feature/9433-polishing-uqs branch September 21, 2021 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

Assignees

@SamuraiKek SamuraiKek

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @SamuraiKek @AlexanderAlferov