Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust recommended actions for risk details screens (EXPOSUREAPP-9222) #4102

Conversation

SamuraiKek
Copy link
Contributor

Compare figma design from the Jira ticket with the app. Please test with all types of risk.

@SamuraiKek SamuraiKek added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Sep 21, 2021
@SamuraiKek SamuraiKek added this to the 2.11.0 milestone Sep 21, 2021
@SamuraiKek SamuraiKek requested review from a team September 21, 2021 13:42
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@mtwalli
Copy link
Contributor

mtwalli commented Sep 22, 2021

Figma
Screenshot 2021-09-22 at 12 33 00

Grey line is missing
Screenshot 2021-09-22 at 12 39 50

@mtwalli mtwalli self-assigned this Sep 22, 2021
@SamuraiKek
Copy link
Contributor Author

Figma
Screenshot 2021-09-22 at 12 33 00

Grey line is missing
Screenshot 2021-09-22 at 12 39 50

Yes, I know, I've seen this too but it's out of the scope of this ticket. These lines should have been added some time ago I think. I tried my best to align the dots and change their size to make it look closer to the design but having those grey lines would imply some kind of custom views I believe.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SamuraiKek SamuraiKek merged commit c5747a1 into release/2.11.x Sep 22, 2021
@SamuraiKek SamuraiKek deleted the feature/9222-adjust-recommended-actions-for-risk-details branch September 22, 2021 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants