Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Auto checkout fix (EXPOSUREAPP-8700) #4152

Merged
merged 20 commits into from
Oct 8, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov commented Sep 30, 2021

Changes

Added non zero check for permanent locations, as it is not possible to create permanent location with zero duration.

Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-8700

How to test

  1. Create non permanent location with:
    a) zero duration
    b) start date differs from end date more than 15 minutes
    c) in future (so endDate is after Now())
  2. Scan it
    3. Check that auto checkout is bigger than 15 minutes (= end date - start date)
    4. Use your time machine to teleport to future 15 minutes and check that checkout was not performed
  3. [Update] According to new data from PO: duration should be the event duration (not larger than 23:45).

@AlexanderAlferov AlexanderAlferov added bug Something isn't working maintainers Tag pull requests created by maintainers labels Sep 30, 2021
@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review September 30, 2021 13:28
@AlexanderAlferov AlexanderAlferov requested a review from a team September 30, 2021 13:28
@jurajkusnier jurajkusnier self-assigned this Oct 1, 2021
@BMItr BMItr self-assigned this Oct 4, 2021
@marcauberer marcauberer added this to the 2.12.0 milestone Oct 4, 2021
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested according to the jira ticket

Steps:

  1. open the app (CWA)
  2. select check-in in the tab-bar
  3. scan the QR-Code of the event
  4. check in

Expected result:

  • automatic check-out at the end of the event didn't happen

@AlexanderAlferov AlexanderAlferov marked this pull request as draft October 5, 2021 14:53
@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review October 6, 2021 13:36
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

image
if no duration is provided, the end time of the event is taken.

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@jurajkusnier jurajkusnier merged commit db64652 into release/2.12.x Oct 8, 2021
@jurajkusnier jurajkusnier deleted the fix/8700-auto-checkout branch October 8, 2021 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants