This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderAlferov
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Sep 30, 2021
jurajkusnier
reviewed
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested according to the jira ticket
Steps:
- open the app (CWA)
- select check-in in the tab-bar
- scan the QR-Code of the event
- check in
Expected result:
- automatic check-out at the end of the event didn't happen
…rn-app/cwa-app-android into fix/8700-auto-checkout
…rn-app/cwa-app-android into fix/8700-auto-checkout
BMItr
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! |
jurajkusnier
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added non zero check for permanent locations, as it is not possible to create permanent location with zero duration.
Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-8700
How to test
a) zero duration
b) start date differs from end date more than 15 minutes
c) in future (so endDate is after Now())
3. Check that auto checkout is bigger than 15 minutes (= end date - start date)4. Use your time machine to teleport to future 15 minutes and check that checkout was not performed