Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

System time dependent text formatting (EXPOSUREAPP-11509) #4787

Merged
merged 38 commits into from
Feb 7, 2022
Merged

System time dependent text formatting (EXPOSUREAPP-11509) #4787

merged 38 commits into from
Feb 7, 2022

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Feb 4, 2022 •
edited by mtwalli

Changes:

  • Format system dependent time
  • All CCLText formatting is happening now in the relevant ViewModel
  • Some fixes for release build
  • Cleanup DccWalletInfo
  • Upgrade AGP version
  • Enhanced the Test menu a bit to give better hint of the calculation status

LukasLechnerDev and others added 28 commits February 2, 2022 11:55
@LukasLechnerDev
Add system-time-dependent CCL Text
e26cd2c
@LukasLechnerDev
Merge branch 'release/2.18.x' into feature/11509-system-time-dependan…
4e109c9 
…t-text-formatting

# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/dccwalletinfo/model/DccWalletInfoOutput.kt
@LukasLechnerDev
Create SystemTimeDependentTextFormatter.kt
9f6a335
@mtwalli
Merge branch 'release/2.18.x' into feature/11509-system-time-dependan…
c8abfe1 
…t-text-formatting
@mtwalli
Move to formatter class
3bcbcbd
@mtwalli
Migrate to formatter in PersonOverview
329abd0
@mtwalli
Fix booster card
1e84397
@mtwalli
fix tests
1149c98
@mtwalli
Format system dependant text
4263db5
@mtwalli
Fix more tests
7452ce6
@mtwalli
Update UrlResourceKtTest.kt
996a424
@mtwalli
Simplify formatting
e8f890e
@mtwalli
Fix test
03d005b
@mtwalli
Upgrade
60efd0d
@mtwalli
Improve test menu
f5b908b
@mtwalli
lint
3a3d9a7
@mtwalli
Jackson Kotlin
6d037a5
@mtwalli
Update DccWalletInfoParserTest.kt
b35c7a5
@mtwalli
release jackson adjustments
3fb09ae
@mtwalli
Update CCLTestFragment.kt
d2856f4
@mtwalli
Cleanup dccWalletinfos leftovers
3c5d9fa
@mtwalli
log
4c3b976
@mtwalli
Unit
b99bbdc
@mtwalli
Docs
271b6c0
@mtwalli
Args
c71446f
@mtwalli
update comments / logs
30e032b
@mtwalli
Docs
f63cdfb
@mtwalli
Update DccWalletInfoCalculationManager.kt
d3d045d
@mtwalli mtwalli marked this pull request as ready for review February 7, 2022 08:46
@mtwalli mtwalli requested a review from a team February 7, 2022 08:46
@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Feb 7, 2022
@mtwalli mtwalli added this to the 2.18.0 milestone Feb 7, 2022
@chiljamgossow chiljamgossow self-assigned this Feb 7, 2022
chiljamgossow
chiljamgossow reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. It would be easier to review if it were separate PRs , one for the scope of the ticket and another for enhancements.

...a-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/dccwalletinfo/model/DccWalletInfoOutput.kt Show resolved Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/ui/text/CCLTextFormatter.kt Show resolved Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/ui/text/CCLTextFormatter.kt Outdated Show resolved Hide resolved
@mtwalli
Copy link
Contributor

mtwalli commented Feb 7, 2022

Thanks for the improvements. It would be easier to review if it were separate PRs , one for the scope of the ticket and another for enhancements.

Sorry about that, It just got bigger and bigger

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.6% 25.6% Coverage
0.0% 0.0% Duplication

BMItr
BMItr approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mtwalli mtwalli merged commit 6a38238 into release/2.18.x Feb 7, 2022
@mtwalli mtwalli deleted the feature/11509-system-time-dependant-text-formatting branch February 7, 2022 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli left review comments

@BMItr BMItr BMItr approved these changes

@chiljamgossow chiljamgossow chiljamgossow approved these changes

Assignees

@BMItr BMItr

@chiljamgossow chiljamgossow

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LukasLechnerDev @mtwalli @BMItr @chiljamgossow