Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

FIX: Export test results shown in contact journal (EXPOSUREAPP-11441) #4812

Merged
merged 7 commits into from
Feb 10, 2022
Merged

FIX: Export test results shown in contact journal (EXPOSUREAPP-11441) #4812

merged 7 commits into from
Feb 10, 2022

Conversation

jurajkusnier
Copy link
Contributor

Testing

  • Scan some positive/negative PCR/RAT tests
  • Check tests in the contact journal
  • Export Entries
  • Tests should be visible in the exported data

Jira Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11441

Contact Journal (Export of Data) Spec

https://github.com/corona-warn-app/cwa-app-tech-spec/blob/main/docs/spec/contact-diary.md#export-of-data

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers labels Feb 9, 2022
@jurajkusnier jurajkusnier added this to the 2.18.0 milestone Feb 9, 2022
@jurajkusnier jurajkusnier requested a review from a team February 9, 2022 15:53
@Ein-Tim Ein-Tim mentioned this pull request Feb 9, 2022
Closed
3 tasks
@BMItr BMItr self-assigned this Feb 10, 2022
@chiljamgossow chiljamgossow self-assigned this Feb 10, 2022
chiljamgossow
chiljamgossow reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, and it works fine if there are also other entries.
But with RAT tests only, there was no entry in the export. Is that intended?

@jurajkusnier
Copy link
Contributor Author

I tested, and it works fine if there are also other entries.
But with RAT tests only, there was no entry in the export. Is that intended?

Fixed and new test case was added

BMItr
BMItr approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
tested on Samsung S20 Device.
image

@mtwalli mtwalli self-assigned this Feb 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.1% 95.1% Coverage
0.0% 0.0% Duplication

@jurajkusnier jurajkusnier merged commit 156f0d9 into release/2.18.x Feb 10, 2022
@jurajkusnier jurajkusnier deleted the fix/11441-test_result_in_contact_journal_export branch February 10, 2022 15:37
@DerVogel2020
Copy link
Contributor

My browser cannot find the specs at

https://github.com/corona-warn-app/cwa-app-tech-spec/blob/main/docs/spec/contact-diary.md#export-of-data

Where can I find them?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli approved these changes

@BMItr BMItr BMItr approved these changes

@chiljamgossow chiljamgossow Awaiting requested review from chiljamgossow

Assignees

@mtwalli mtwalli

@BMItr BMItr

@chiljamgossow chiljamgossow

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jurajkusnier @DerVogel2020 @mtwalli @BMItr @chiljamgossow