Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

"Impfstatus" shows wrong infos (EXPOSUREAPP-11833) #4851

Merged
merged 40 commits into from
Feb 21, 2022
Merged

"Impfstatus" shows wrong infos (EXPOSUREAPP-11833) #4851

merged 40 commits into from
Feb 21, 2022

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Feb 17, 2022 •
edited by mtwalli

This PR addresses EXPOSUREAPP-11833

  • Delay helpers have been removed

  • DCCWalletInfo is triggered if there were changes that lead to DccWalletInfo calculation such as:

    • Register Dcc
    • Recycle Dcc
    • Restore Dcc
    • Retrieve Dcc

  • unification of some structures

  • potentially better performance

How test ?

  • Scan certificates for many persons as many as possible and scan certificates for each person as many as possible
  • Scan certificate from the ticket and follow the steps that triggers change in G-status
  • Make sure that changes that are not intended to trigger DccWalletInfo update such as badge / and validity state changes don't trigger dcc wallet info calculation

@BMItr BMItr requested a review from a team February 17, 2022 20:07
@BMItr BMItr marked this pull request as draft February 17, 2022 20:07
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Feb 17, 2022
@BMItr BMItr added this to the 2.18.0 milestone Feb 17, 2022
@BMItr BMItr mentioned this pull request Feb 17, 2022
Closed
@BMItr BMItr marked this pull request as ready for review February 17, 2022 20:24
@BMItr BMItr marked this pull request as ready for review February 18, 2022 18:00
@mtwalli mtwalli changed the title Status wrong issues, performance & delay improvements for 2.18 (EXPOSUREAPP-11833) "Impfstatus" shows wrong infos (EXPOSUREAPP-11833) Feb 18, 2022
@mtwalli mtwalli added bug Something isn't working prio PRs to review first. labels Feb 18, 2022
@LukasLechnerDev LukasLechnerDev self-assigned this Feb 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

LukasLechnerDev
LukasLechnerDev approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with many certificates. DccWalletInfo is only recalculated when it should.

Very nice work @BMItr and @mtwalli . That's a big improvement 👍

@mtwalli mtwalli merged commit 497e5d9 into release/2.18.x Feb 21, 2022
@mtwalli mtwalli deleted the fix/11833-impfstatus-wrong-for-2-18 branch February 21, 2022 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@mtwalli mtwalli mtwalli approved these changes

Assignees

@LukasLechnerDev LukasLechnerDev

@mtwalli mtwalli

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BMItr @LukasLechnerDev @mtwalli