Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fault tolerant name handling for certificates (EXPOSUREAPP-11617) #4858

Merged
merged 41 commits into from
Feb 24, 2022

Conversation

jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier commented Feb 18, 2022

Fault-tolerant name handling for certificates

  • Group DCCs with relaxed name comparison, implemented in groupByPerson()
  • Vaccination Storage Migration + Deeplinks - will be implemented in separated PR

Testing

  • Scan multiple certificates and check if they are mapped according to the specs
  • eg:
cwa tc gen -e wru -s dob="1988-01-01" nam.fn="Dr Pablo" nam.gn="Simpson"
cwa tc gen -e wru -s dob="1988-01-01" nam.fn="Dr José" nam.gn="Simpson"
cwa rc gen -e wru -s dob="1988-01-01" nam.fn="Pablo José Paula" nam.gn="Simpson"

cwa tc gen -e wru -s dob="1988-01-01" nam.fn="Cipriano" nam.gn="Simpson"
cwa tc gen -e wru -s dob="1988-01-01" nam.fn="Juan" nam.gn="Simpson"
cwa rc gen -e wru -s dob="1988-01-01" nam.fn="Cipriano Juan Paula" nam.gn="Simpson"
  • this should be displayed as one person when you scan all certificates

Jira Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11617

@jurajkusnier jurajkusnier added the maintainers Tag pull requests created by maintainers label Feb 18, 2022
@jurajkusnier jurajkusnier added this to the 2.19.0 milestone Feb 18, 2022
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/dccwalletinfo/calculation/DccWalletInfoCalculationManager.kt
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works as it should.

Code also looks pretty solid 👍

LGTM, only some comments about possible adjustments

@BMItr BMItr self-assigned this Feb 23, 2022
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/common/certificate/CertificatePersonIdentifier.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/core/PersonCertificatesSettings.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/person/core/PersonCertificatesStorageTest.kt
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

83.4% 83.4% Coverage
1.4% 1.4% Duplication

@BMItr
Copy link
Contributor

BMItr commented Feb 24, 2022

LGTM 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants