This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 497
Fault tolerant name handling for certificates (EXPOSUREAPP-11617) #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…22-11716-grouping-method-with-tests # Conflicts: # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/CovidCertificateTestComponent.kt
…hod-with-tests' into feature/11722-11716-grouping-method-with-tests
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ccl/dccwalletinfo/calculation/DccWalletInfoCalculationManager.kt
...Warn-App/src/test/java/de/rki/coronawarnapp/ccl/holder/grouping/DccGroupingExtensionsTest.kt
Outdated
Show resolved
Hide resolved
...java/de/rki/coronawarnapp/covidcertificate/common/certificate/CertificatePersonIdentifier.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/de/rki/coronawarnapp/covidcertificate/person/core/PersonCertificatesProvider.kt
Outdated
Show resolved
Hide resolved
LukasLechnerDev
previously approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and works as it should.
Code also looks pretty solid 👍
LGTM, only some comments about possible adjustments
BMItr
reviewed
Feb 23, 2022
...java/de/rki/coronawarnapp/covidcertificate/common/certificate/CertificatePersonIdentifier.kt
Show resolved
Hide resolved
BMItr
reviewed
Feb 23, 2022
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/preferences/FlowPreference.kt
Show resolved
Hide resolved
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/common/certificate/CertificatePersonIdentifier.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/core/PersonCertificatesSettings.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/person/core/PersonCertificatesStorageTest.kt
LukasLechnerDev
approved these changes
Feb 24, 2022
Kudos, SonarCloud Quality Gate passed! |
BMItr
approved these changes
Feb 24, 2022
LGTM 👌 |
This was referenced Mar 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fault-tolerant name handling for certificates
groupByPerson()
Testing
Jira Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11617