Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Unit tests replacement (EXPOSUREAPP-11940) #4879

Merged
merged 14 commits into from
Mar 3, 2022

Conversation

chiljamgossow
Copy link
Contributor

more resilience and unit tests
on top of #4877

@chiljamgossow chiljamgossow added the maintainers Tag pull requests created by maintainers label Mar 1, 2022
@chiljamgossow chiljamgossow added this to the 2.19.0 milestone Mar 1, 2022
@chiljamgossow chiljamgossow requested a review from a team March 1, 2022 10:37
Base automatically changed from feature/11942-final-wiring to release/2.19.x March 1, 2022 14:28
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 3, 2022
@@ -76,7 +76,8 @@ class PersonCertificatesProviderTest : BaseTest() {

private val rcSet = setOf(recoveryCertA, recoveryCertB)
private val tcSet = setOf(testCertA, testCertB)
// private val vcInfoSet = setOf(vaccinatedPersonA)

// private val vcInfoSet = setOf(vaccinatedPersonA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is coming from Juraj's PR

Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the additional tests.

@mtwalli mtwalli self-assigned this Mar 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@chiljamgossow chiljamgossow merged commit be88455 into release/2.19.x Mar 3, 2022
@chiljamgossow chiljamgossow deleted the feature/11940-unit-tests branch March 3, 2022 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants