Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

FIX: App crash when marking cert. as personal cert. (EXPOSUREAPP-12116) #4900

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

jurajkusnier
Copy link
Contributor

Proguard update to prevent app crash

Testing

  • make release build
  • scan any certificate
  • mark certificate as personal certificate
  • app shouldn't crash

Jira Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-12116

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers labels Mar 4, 2022
@jurajkusnier jurajkusnier added this to the 2.19.0 milestone Mar 4, 2022
@jurajkusnier jurajkusnier requested a review from a team March 4, 2022 10:25
@jurajkusnier jurajkusnier added the prio PRs to review first. label Mar 4, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli self-assigned this Mar 4, 2022
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 4, 2022
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No crash on release build. LGTM

@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jurajkusnier jurajkusnier merged commit 4025128 into release/2.19.x Mar 4, 2022
@jurajkusnier jurajkusnier deleted the fix/12116-personal_cert_crash branch March 4, 2022 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants