Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

CoronaTest refactoring (EXPOSUREAPP-12330) #4970

Merged
merged 11 commits into from Mar 22, 2022

Conversation

chiljamgossow
Copy link
Contributor

@chiljamgossow chiljamgossow commented Mar 21, 2022

Split interface to facilitate differentiation between personal and family tests

changes come from renaming, logic stays the same

@chiljamgossow chiljamgossow requested a review from a team March 21, 2022 18:17
@chiljamgossow chiljamgossow added the maintainers Tag pull requests created by maintainers label Mar 21, 2022
@chiljamgossow chiljamgossow added this to the 2.21.0 milestone Mar 21, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌, one comment , which can be addressed in followup PR

val qrCodeHash: String?
}

interface KeySubmission {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be more specific here as it is for test CoronaTestKeySubmission or CoronaTestSubmission ?

@mtwalli mtwalli self-assigned this Mar 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek self-assigned this Mar 22, 2022
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chiljamgossow chiljamgossow merged commit 14159e0 into release/2.21.x Mar 22, 2022
@chiljamgossow chiljamgossow deleted the feature/12330-data-structure branch March 22, 2022 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants