Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

[Feature] Family test list (EXPOSUREAPP-12321, EXPOSUREAPP-12327) #5014

Merged
merged 29 commits into from Mar 31, 2022
Merged

[Feature] Family test list (EXPOSUREAPP-12321, EXPOSUREAPP-12327) #5014

merged 29 commits into from Mar 31, 2022

Conversation

AlexanderAlferov
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov commented Mar 30, 2022 •
edited

Whats new

Family test list screen.

Screenshot 2022-03-30 at 22 55 54

Story

How to test

  1. Take a cup of tea/coffee - this would be a long ride
  2. Using INT env scan both PCR and RAT types for POSITIVE, NEGATIVE, INVALID
  3. Go to family tests fragment and check, that every test appeared as it should be
  4. Check all tests with notification badge
  5. Navigate back to main fragment
  6. Navigate back again to family tests fragment - check that all notification badges are gone
  7. Switch to WRU env and check tests
  8. Delete one test by swiping left and confirm in alert dialog
  9. Delete one test by swiping right and confirm in alert dialog
  10. Delete one test by pressing delete button (should be at least one in REDEEMED state)
  11. Delete all left tests by using menu in top right corner (confirmation dialog should also appear)
  12. Go to recycle bin and restore tests
  13. Go to phone system settings and time travel (+10 years will be just fine)
  14. Go back to family tests fragment - NEGATIVE PCR should became OUTDATED with delete button
  15. Press that delete button
  16. Delete all tests
  17. Switch to Night Mode
  18. Anger
  19. Denial
  20. Acceptance
  21. Repeat steps 2-16 and check if everything is okay in Night Mode

To Do

  • Navigation to test details
  • Update Invalid and Outdated card icons
  • Update confirmation dialog text

@AlexanderAlferov
Initial layouts
f00b41a
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/2.21.x' into feature/123…
c5a8437 
…21-family-test-list

# Conflicts:
#	Corona-Warn-App/src/main/res/layout/fragment_test_registration_selection.xml
@AlexanderAlferov
All cards layout + strings
ad6cd9a
@AlexanderAlferov
Cards and adapter
cf1ba35
@AlexanderAlferov
Cards and view model
935f844
@AlexanderAlferov
Cards and view model
cdcd34b
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/2.21.x' into feature/123…
49622d4 
…21-family-test-list
@AlexanderAlferov
View model fix and module
98d6d22
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/2.21.x' into feature/123…
49f49d6 
…21-family-test-list
@AlexanderAlferov
View model refactoring
a6460ce
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/2.21.x' into feature/123…
f888e34 
…21-family-test-list
@AlexanderAlferov
Cards fix
0219e04
@AlexanderAlferov
Mass deletion and refresh
d8de0c4
@AlexanderAlferov
Notification badge
fea86bd
@AlexanderAlferov
Tests and fixes
ea454e3
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/2.21.x' into feature/123…
afcdb03 
…21-family-test-list

# Conflicts:
#	Corona-Warn-App/src/main/res/layout/fragment_family_test_list.xml
@AlexanderAlferov
Style fix
29d0a65
@AlexanderAlferov AlexanderAlferov added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. author merge PR to be merged by author labels Mar 30, 2022
@AlexanderAlferov AlexanderAlferov added this to the 2.21.0 milestone Mar 30, 2022
@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review March 30, 2022 20:21
@AlexanderAlferov AlexanderAlferov requested review from a team March 30, 2022 20:22
CV113
CV113 previously approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@CV113 CV113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

KathrinLuecke
KathrinLuecke suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

mtwalli
mtwalli reviewed Mar 31, 2022
View reviewed changes
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/familytest/core/model/CoronaTest.kt Show resolved Hide resolved
...Warn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListFragment.kt Show resolved Hide resolved
...arn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListViewModel.kt Outdated Show resolved Hide resolved
...arn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListViewModel.kt Outdated Show resolved Hide resolved
...arn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListViewModel.kt Show resolved Hide resolved
...arn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListViewModel.kt Outdated Show resolved Hide resolved
...arn-App/src/main/java/de/rki/coronawarnapp/familytest/ui/testlist/FamilyTestListViewModel.kt Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/family_pcr_test_card_positiv.xml Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/family_pcr_test_card_positiv.xml Show resolved Hide resolved
@mtwalli mtwalli self-assigned this Mar 31, 2022
@mtwalli mtwalli added the prio PRs to review first. label Mar 31, 2022
@jurajkusnier jurajkusnier self-assigned this Mar 31, 2022
mtwalli
mtwalli previously approved these changes Mar 31, 2022
View reviewed changes
@mtwalli
Copy link
Contributor

mtwalli commented Mar 31, 2022

@AlexanderAlferov , Very neat UI!
Thanks for the hard work , you have done in CWA

jurajkusnier
jurajkusnier previously approved these changes Mar 31, 2022
View reviewed changes
@mtwalli mtwalli dismissed stale reviews from jurajkusnier and themself via f08c6e8 March 31, 2022 17:23
@BMItr BMItr self-assigned this Mar 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
12.6% 12.6% Duplication

@mtwalli mtwalli merged commit 96882c2 into release/2.21.x Mar 31, 2022
@mtwalli mtwalli deleted the feature/12321-family-test-list branch March 31, 2022 17:43
KathrinLuecke
KathrinLuecke reviewed Apr 1, 2022
View reviewed changes
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KathrinLuecke KathrinLuecke KathrinLuecke requested changes

@mtwalli mtwalli mtwalli approved these changes

@BMItr BMItr BMItr approved these changes

@jurajkusnier jurajkusnier jurajkusnier left review comments

@CV113 CV113 CV113 left review comments

Assignees

@jurajkusnier jurajkusnier

@mtwalli mtwalli

@BMItr BMItr

Labels
author merge PR to be merged by author maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexanderAlferov @mtwalli @jurajkusnier @BMItr @KathrinLuecke @CV113