Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Family tests fixes (DEV) #5020

Merged
merged 11 commits into from Apr 1, 2022
Merged

Conversation

SamuraiKek
Copy link
Contributor

Further adapting the invalid test result screen and some polishing for the person name.

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Mar 31, 2022
@SamuraiKek SamuraiKek added this to the 2.21.0 milestone Mar 31, 2022
@SamuraiKek SamuraiKek requested a review from a team March 31, 2022 17:45
@SamuraiKek SamuraiKek requested a review from a team March 31, 2022 18:21
mtwalli
mtwalli previously approved these changes Mar 31, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli self-assigned this Apr 1, 2022
mtwalli
mtwalli previously approved these changes Apr 1, 2022
@mtwalli mtwalli changed the title Family test result fixes (DEV) Family tests fixes (DEV) Apr 1, 2022
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@BMItr BMItr self-assigned this Apr 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 29c485a into release/2.21.x Apr 1, 2022
@mtwalli mtwalli deleted the feature/dev-family-test-result-fixes branch April 1, 2022 09:14
SamuraiKek added a commit that referenced this pull request Apr 5, 2022
* Minor fixes and adjustments for test result screens.

* Right time based on test type

* Add time based on test type in result screens.

* Fix capital text

* Fix dialog text

* Fix navigation

* lint

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: BMItr <Berndus@gmx.de>
chiljamgossow pushed a commit that referenced this pull request Apr 6, 2022
* Minor fixes and adjustments for test result screens.

* Right time based on test type

* Add time based on test type in result screens.

* Fix capital text

* Fix dialog text

* Fix navigation

* lint

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Co-authored-by: BMItr <Berndus@gmx.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants