Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Notification trigger adjustments (EXPOSUREAPP-12484) #5062

Merged
merged 15 commits into from Apr 7, 2022
Merged

Notification trigger adjustments (EXPOSUREAPP-12484) #5062

merged 15 commits into from Apr 7, 2022

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Apr 7, 2022

This PR addresses EXPOSUREAPP-12484
Trigger behaviour for notfications has been optimizied.

How to test:

  • scan invalid, blocked, expired certificates
  • check the notifications (see ticket for details and cases)

@BMItr BMItr requested a review from a team April 7, 2022 09:43
@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Apr 7, 2022
@BMItr BMItr added this to the 2.21.0 milestone Apr 7, 2022
@BMItr BMItr added the prio PRs to review first. label Apr 7, 2022
@chiljamgossow chiljamgossow self-assigned this Apr 7, 2022
@mtwalli mtwalli self-assigned this Apr 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.3% 85.3% Coverage
0.0% 0.0% Duplication

chiljamgossow
chiljamgossow reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the certificate in the ticket on WRU, but got no notification. It should come immediately, correct? Have you tested successfully?

@BMItr BMItr merged commit 5aed9dc into release/2.21.x Apr 7, 2022
@BMItr BMItr deleted the fix/12484-Notification-Trigger-Adjustments branch April 7, 2022 12:58
schauersbergern pushed a commit that referenced this pull request Apr 27, 2022
@BMItr @mtwalli @schauersbergern
Notification trigger adjustments (EXPOSUREAPP-12484) (#5062)
9b8c557 
* Not needed because shareLatest takes care of that

* Introduce DccExpirationChangeObserver

* Log onStart

* Singleton

* Removed DccExpirationNotificationService fro viewmodel

* Do not trigger when empty

* Setup DccExpirationChangeObserver

* Create DccExpirationChangeObserverTest.kt

* clean

* Use maplatest

* Removed unnecessary foreground check

* Removed drop

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli approved these changes

@chiljamgossow chiljamgossow chiljamgossow approved these changes

Assignees

@mtwalli mtwalli

@chiljamgossow chiljamgossow

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BMItr @mtwalli @chiljamgossow