Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Travelbutton wrongly active (EXPOSUREAPP-12659) #5071

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

schauersbergern
Copy link
Contributor

@schauersbergern schauersbergern commented Apr 8, 2022

Setting the isLoading Property makes the button active so its only set when the certificate is not blocked

Testing Tip:
set this in CwaCovidCertificate.kt
val isNotBlocked get() = false

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-12659

@schauersbergern schauersbergern requested a review from a team April 8, 2022 13:46
mtwalli
mtwalli previously approved these changes Apr 8, 2022
@mtwalli mtwalli self-assigned this Apr 8, 2022
@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels Apr 8, 2022
@mtwalli mtwalli added this to the 2.22.0 milestone Apr 8, 2022
@chiljamgossow chiljamgossow self-assigned this Apr 11, 2022
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 49c2fa4 into release/2.22.x Apr 12, 2022
@mtwalli mtwalli deleted the fix/12659-travelbutton-wrongly-active branch April 12, 2022 11:06
schauersbergern added a commit that referenced this pull request Apr 27, 2022
* only set loading status if enabled

* Change condition for set loading state

* change ProgressLoadingButton to use isClaickable property to deactivate on loading state

Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants