This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Travelbutton wrongly active (EXPOSUREAPP-12659) #5071
Merged
mtwalli
merged 5 commits into
release/2.22.x
from
fix/12659-travelbutton-wrongly-active
Apr 12, 2022
Merged
Travelbutton wrongly active (EXPOSUREAPP-12659) #5071
mtwalli
merged 5 commits into
release/2.22.x
from
fix/12659-travelbutton-wrongly-active
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
previously approved these changes
Apr 8, 2022
mtwalli
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Apr 8, 2022
...ava/de/rki/coronawarnapp/covidcertificate/person/ui/details/items/RecoveryCertificateCard.kt
Outdated
Show resolved
Hide resolved
mtwalli
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Apr 12, 2022
schauersbergern
added a commit
that referenced
this pull request
Apr 27, 2022
* only set loading status if enabled * Change condition for set loading state * change ProgressLoadingButton to use isClaickable property to deactivate on loading state Co-authored-by: Mohamed Metwalli <mohamed.metwalli@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the isLoading Property makes the button active so its only set when the certificate is not blocked
Testing Tip:
set this in CwaCovidCertificate.kt
val isNotBlocked get() = false
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-12659