Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Rapid Test Profile List Screen (EXPOSUREAPP-12606) #5077

Merged

Conversation

SamuraiKek
Copy link
Contributor

Screen Shot 2022-04-11 at 18 05 36

Currently using dummy data. Should work once #5074 is merged

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Apr 11, 2022
@SamuraiKek SamuraiKek added this to the 2.22.0 milestone Apr 11, 2022
@SamuraiKek SamuraiKek requested review from a team April 11, 2022 15:13
KathrinLuecke
KathrinLuecke previously approved these changes Apr 11, 2022
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@chiljamgossow chiljamgossow self-assigned this Apr 11, 2022
@SamuraiKek SamuraiKek changed the title Rapid Test Profile Sist Screen (EXPOSUREAPP-12606) Rapid Test Profile List Screen (EXPOSUREAPP-12606) Apr 12, 2022
@jurajkusnier jurajkusnier self-assigned this Apr 13, 2022
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jurajkusnier
Copy link
Contributor

I get screenshot with missing QR code when running RATProfileQrCodeFragmentTest
image

@SamuraiKek
Copy link
Contributor Author

I get screenshot with missing QR code when running RATProfileQrCodeFragmentTest

I will address this in my Screenshots PR. There's still a few adjustments that I need to do.

…profile details screen after creating a new profile.
…st/rat/profile/list/items/ProfileCard.kt

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
…st/rat/profile/list/ProfileListViewModel.kt

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge

Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

4.4% 4.4% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek merged commit ea6df13 into release/2.22.x Apr 13, 2022
@SamuraiKek SamuraiKek deleted the feature/12606-create-rapid-test-profile-list-screen branch April 13, 2022 14:12
schauersbergern pushed a commit that referenced this pull request Apr 27, 2022
* Add boilerplate for profile list.

* Wire up navigation for info screen.

* Add navigation to profile creation fragment.

* Add profile card and navigation to details.

* Lint fix.

* Renamed class.

* Address comments.

* Change id to Int type.

* Passing navarg id as string.

* Revert navarg id to type int.

* More id passing between fragments and tests fix.

* Fix test.

* Removed unnecessary string builder and adjusted navigation back from profile details screen after creating a new profile.

* Update Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/coronatest/rat/profile/list/items/ProfileCard.kt

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>

* Update Corona-Warn-App/src/main/res/layout/profile_list_fragment.xml

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>

* Update Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/coronatest/rat/profile/list/ProfileListViewModel.kt

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants