Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Swipe to delete for certificates (EXPOSUREAPP-11224) #5096

Merged
merged 14 commits into from
Apr 27, 2022

Conversation

schauersbergern
Copy link
Contributor

Implements swipe to delete for certificates displayed at the bottom of the person detail view

@schauersbergern schauersbergern added the maintainers Tag pull requests created by maintainers label Apr 19, 2022
@schauersbergern schauersbergern requested a review from a team April 19, 2022 06:33
@SamuraiKek SamuraiKek self-assigned this Apr 19, 2022
SamuraiKek
SamuraiKek previously approved these changes Apr 19, 2022
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chiljamgossow chiljamgossow self-assigned this Apr 20, 2022
@schauersbergern
Copy link
Contributor Author

Resolved conflicts and rebased to 2.22

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.5% 8.5% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely

@SamuraiKek SamuraiKek merged commit ea20f7b into release/2.22.x Apr 27, 2022
@SamuraiKek SamuraiKek deleted the feature/11224-certificate_swipe_delete branch April 27, 2022 07:47
schauersbergern added a commit that referenced this pull request Apr 27, 2022
* Add swipe to delete to recovery-, test- and vaccination- certificate in persons detail fragment

* Add deletion dialog handling

* Fix tests

* Fix detekt

* Add null check

* fix lint

Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Co-authored-by: Chilja Gossow <49635654+chiljamgossow@users.noreply.github.com>
Co-authored-by: Marc Auberer <marc.auberer@chillibits.com>
Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants