This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Swipe to delete for certificates (EXPOSUREAPP-11224) #5096
Merged
SamuraiKek
merged 14 commits into
release/2.22.x
from
feature/11224-certificate_swipe_delete
Apr 27, 2022
Merged
Swipe to delete for certificates (EXPOSUREAPP-11224) #5096
SamuraiKek
merged 14 commits into
release/2.22.x
from
feature/11224-certificate_swipe_delete
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in persons detail fragment
SamuraiKek
previously approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
...ava/de/rki/coronawarnapp/covidcertificate/person/ui/details/items/RecoveryCertificateCard.kt
Outdated
Show resolved
Hide resolved
Resolved conflicts and rebased to 2.22 |
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely
SamuraiKek
approved these changes
Apr 27, 2022
schauersbergern
added a commit
that referenced
this pull request
Apr 27, 2022
* Add swipe to delete to recovery-, test- and vaccination- certificate in persons detail fragment * Add deletion dialog handling * Fix tests * Fix detekt * Add null check * fix lint Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com> Co-authored-by: Chilja Gossow <49635654+chiljamgossow@users.noreply.github.com> Co-authored-by: Marc Auberer <marc.auberer@chillibits.com> Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements swipe to delete for certificates displayed at the bottom of the person detail view