This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix certificate deletion app crash (EXPOSUREAPP-12875) #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuraiKek
added
bug
BMItr
reviewed
Apr 26, 2022
| @@ -116,7 +116,8 @@ class PersonDetailsViewModel @AssistedInject constructor( | |||
|
|
|||
| return UiState( | |||
There was a problem hiding this comment.
Handle the logic in the viewmodel and send an gobackEvent if the corresponding numberofCertificates is reached
BMItr
reviewed
Apr 26, 2022
...rki/coronawarnapp/covidcertificate/recovery/ui/details/RecoveryCertificateDetailsFragment.kt
Show resolved
Hide resolved
BMItr
reviewed
Apr 26, 2022
...java/de/rki/coronawarnapp/covidcertificate/test/ui/details/TestCertificateDetailsFragment.kt
Show resolved
Hide resolved
BMItr
reviewed
Apr 26, 2022
...a/de/rki/coronawarnapp/covidcertificate/vaccination/ui/details/VaccinationDetailsFragment.kt
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Apr 28, 2022
BMItr
approved these changes
Apr 28, 2022
jurajkusnier
added a commit
that referenced
this pull request
Apr 29, 2022
This reverts commit 66bcbb4
schauersbergern
pushed a commit
that referenced
this pull request
May 4, 2022
* Prevent app from crashing when deleting last certificate in the list. * Fix lint. * Fix app crashing when trying to display the badge on the booster card. Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com> Co-authored-by: Marc Auberer <marc.auberer@chillibits.com> Co-authored-by: BMItr <Berndus@gmx.de> Co-authored-by: Chilja Gossow <49635654+chiljamgossow@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when removing all the certificates of a person, the app would crash upon deleting the last remaining certificate. This fix skips over the
PersonDetailsFragmententirely and goes straing toPersonOverviewFragmentwhen deleting the last certificate of a person.To test, scan one or more certificate for the same person and then delete them one by one.