Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add case for not attached dcc in FamilyTest (EXPOSUREAPP-12941) #5143

Merged
merged 7 commits into from
May 2, 2022
Merged

Add case for not attached dcc in FamilyTest (EXPOSUREAPP-12941) #5143

merged 7 commits into from
May 2, 2022

Conversation

schauersbergern
Copy link
Contributor

Testing:

Attached dcc:

  • generate qr with: "cwa rat -r negative --tc --dgc -e wru"
  • after scan choose "register for others", add name, tap consent button, you should then be navigated to dcc request screen

No dcc:

  • generate qr with: "cwa rat -r negative -e wru"
  • after scan choose "register for others", add name, tap consent button, family test is instantly downloaded

@schauersbergern schauersbergern added bug Something isn't working maintainers Tag pull requests created by maintainers labels May 2, 2022
@schauersbergern schauersbergern requested a review from a team May 2, 2022 10:13
@SamuraiKek SamuraiKek self-assigned this May 2, 2022
@BMItr BMItr self-assigned this May 2, 2022
@BMItr
Copy link
Contributor

BMItr commented May 2, 2022

please add unit test(s) if possible :octocat:

BMItr
BMItr approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit tests in a follow up PR.
lgtm!

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@BMItr BMItr merged commit 3118ac9 into release/2.22.x May 2, 2022
@BMItr BMItr deleted the fix/12941-family_consent_no_dcc branch May 2, 2022 14:53
schauersbergern added a commit that referenced this pull request May 4, 2022
@schauersbergern @jurajkusnier
Add case for not attached dcc in FamilyTest (EXPOSUREAPP-12941) (#5143)
e4a5c97 
* add case for no attached dcc in FamilyTest

* change navigation to doNavigate
fix tests

* Change viewmodel state to combine loading and submittable state

* Remove unnecessary flow conversion

Co-authored-by: Juraj Kusnier <jurajkusnier@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chiljamgossow chiljamgossow chiljamgossow left review comments

@SamuraiKek SamuraiKek SamuraiKek approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@SamuraiKek SamuraiKek

@BMItr BMItr

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@schauersbergern @BMItr @SamuraiKek @chiljamgossow @jurajkusnier