This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Family consent viewModel tests (EXPOSUREAPP-12545) #5148
Merged
chiljamgossow
merged 10 commits into
release/2.23.x
from
fix/12941-family_consent_no_dcc_test
May 10, 2022
Merged
Family consent viewModel tests (EXPOSUREAPP-12545) #5148
chiljamgossow
merged 10 commits into
release/2.23.x
from
fix/12941-family_consent_no_dcc_test
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...p/src/test/java/de/rki/coronawarnapp/familytest/ui/consent/FamilyTestConsentViewModelTest.kt
Show resolved
Hide resolved
...p/src/test/java/de/rki/coronawarnapp/familytest/ui/consent/FamilyTestConsentViewModelTest.kt
Outdated
Show resolved
Hide resolved
...p/src/test/java/de/rki/coronawarnapp/familytest/ui/consent/FamilyTestConsentViewModelTest.kt
Outdated
Show resolved
Hide resolved
remove copy paste fauxpass
mtwalli
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mtwalli
reviewed
May 10, 2022
...n-App/src/main/java/de/rki/coronawarnapp/familytest/ui/consent/FamilyTestConsentViewModel.kt
Show resolved
Hide resolved
chiljamgossow
approved these changes
May 10, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FamilyTestConsentViewModelTest
remarks:
for tests nameChanged and nameNotChanged viewModelDcc.isSubmittable.value remains null so these two tests fail,
maybe someone could point me in the right direction whats missing