Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Upgrade to coroutines v1.6.1 (EXPOSUREAPP-12370) #5150

Merged
merged 64 commits into from
May 10, 2022
Merged

Upgrade to coroutines v1.6.1 (EXPOSUREAPP-12370) #5150

merged 64 commits into from
May 10, 2022

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented May 4, 2022 •
edited

  • Replace runBlockingTest2 with runTest2 and fix its behavior
  • Replace TestCoroutineScope with TestScope
  • Replace runBlockingTest with runTest or runTest(UnconfinedTestDispatcher())
  • Fix test cases that were actually failing ,but did not show up because of faulty runBlockingTest2
    Note : There are a few test cases the needs to be updated or migrated about ​4​ ,but those can be addressed later

Ticket

⛽ https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-12370

@mtwalli mtwalli added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels May 4, 2022
@mtwalli mtwalli added this to the 2.23.x milestone May 4, 2022
@mtwalli mtwalli changed the title Upgrade to coroutines v1.6.1 (EXPOSUREAPP-12370) Upgrade to coroutines v1.6.1 (EXPOSUREAPP-12370) May 4, 2022
@BMItr BMItr self-assigned this May 5, 2022
@mtwalli mtwalli marked this pull request as ready for review May 9, 2022 15:44
@mtwalli mtwalli requested a review from a team May 9, 2022 15:44
BMItr
BMItr previously approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my browser cache didnt manage the huge diff 😄
beside of this: LVGTM! 👌

@jurajkusnier jurajkusnier self-assigned this May 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit c189ee7 into release/2.23.x May 10, 2022
@mtwalli mtwalli deleted the feature/12370-upgrade-coroutines branch May 10, 2022 10:52
@mtwalli mtwalli restored the feature/12370-upgrade-coroutines branch May 10, 2022 11:01
@mtwalli mtwalli deleted the feature/12370-upgrade-coroutines branch May 10, 2022 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@jurajkusnier jurajkusnier

@BMItr BMItr

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.23.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @jurajkusnier @BMItr