This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Submit analytics date conversion (EXPOSUREAPP-12616) #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauersbergern
added
bug
| @@ -74,7 +75,7 @@ class ExposureRiskMetadataDonor @Inject constructor( | |||
| val riskLevelPtForMetadata = lastPTRiskResult.toMetadataRiskLevel() | |||
| val mostRecentDateAtPtRiskLevel = lastPTRiskResult | |||
| .mostRecentDateAtRiskState | |||
| ?.toDateTimeAtStartOfDay() | |||
| ?.toDateTimeAtStartOfDay(DateTimeZone.UTC) | |||
| ?.toInstant() | |||
There was a problem hiding this comment.
Can you add a unit test for that?
There was a problem hiding this comment.
Sure, unit test added
There was a problem hiding this comment.
Thanks for the test. Can you add one for the donor to make sure this is and stays fixed?
There was a problem hiding this comment.
Changed present tests to use toDateTimeAtStartOfDayUtc
chiljamgossow
approved these changes
May 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
SamuraiKek
approved these changes
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the device Timezone for toDateTimeAtStartOfDay results in a date two hours before midnight the day before.
Using UTC Timezone results in midnight of the same day