Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Revocation repository exception (DEV) #5163

Merged
merged 2 commits into from
May 10, 2022
Merged

Revocation repository exception (DEV) #5163

merged 2 commits into from
May 10, 2022
+21 −1

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented May 9, 2022

This PR addresses a potential fix for the revocation repository for a little amount of users.
See vitals for details.

How to test:

  • Scan in a revoced certifcate
  • Check if everything looks as expected

@BMItr BMItr requested a review from a team May 9, 2022 18:44
@BMItr BMItr added maintainers Tag pull requests created by maintainers enhancement Improvement of an existing feature labels May 9, 2022
@BMItr BMItr added this to the 2.23.x milestone May 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@schauersbergern schauersbergern self-assigned this May 10, 2022
@jurajkusnier jurajkusnier self-assigned this May 10, 2022
schauersbergern
schauersbergern approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@schauersbergern schauersbergern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with single and multiple revoked certificates

jurajkusnier
jurajkusnier approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier merged commit d8643fc into release/2.23.x May 10, 2022
@jurajkusnier jurajkusnier deleted the fix/revocation-repo-exception branch May 10, 2022 09:33
@hassantaj2022 hassantaj2022 mentioned this pull request May 17, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@schauersbergern schauersbergern schauersbergern approved these changes

Assignees

@jurajkusnier jurajkusnier

@schauersbergern schauersbergern

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.23.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BMItr @jurajkusnier @schauersbergern