Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust Navigation for PDF Export (EXPOSUREAPP-13438, EXPOSUREAPP-13439) #5299

Merged
merged 6 commits into from Jun 30, 2022
Merged

Adjust Navigation for PDF Export (EXPOSUREAPP-13438, EXPOSUREAPP-13439) #5299

merged 6 commits into from Jun 30, 2022

Conversation

schauersbergern
Copy link
Contributor

Quitting Export, Export errors and back navigation should all go back to personOverviewFragment
Ticket
Ticket

@schauersbergern schauersbergern added bug Something isn't working maintainers Tag pull requests created by maintainers labels Jun 24, 2022
@schauersbergern schauersbergern added this to the 2.25.x milestone Jun 24, 2022
@schauersbergern schauersbergern requested a review from a team June 24, 2022 09:50
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited

Unit Test Results - Device Release

   555 files  ±0     555 suites  ±0   5m 48s ⏱️ -7s
2 742 tests ±0  2 742 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 791 runs  ±0  2 791 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d70c0a1. ± Comparison against base commit 5a68664.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited

Unit Test Results - Device For Tester Release

   558 files  ±0     558 suites  ±0   5m 33s ⏱️ -7s
2 748 tests ±0  2 748 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 797 runs  ±0  2 797 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d70c0a1. ± Comparison against base commit 5a68664.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited

Firebase Test Results

    2 files  ±0      2 suites  ±0   4m 29s ⏱️ +23s
129 tests ±0  129 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
258 runs  ±0  258 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d70c0a1. ± Comparison against base commit 5a68664.

♻️ This comment has been updated with latest results.

@SamuraiKek SamuraiKek self-assigned this Jun 27, 2022
@chiljamgossow chiljamgossow self-assigned this Jun 27, 2022
chiljamgossow
chiljamgossow reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation from the dialogs are ok.
When pressing back from the pdf overview I would expect to see the info screen again, not the overview. Was that requested?

@SamuraiKek
Copy link
Contributor

Navigation from the dialogs are ok. When pressing back from the pdf overview I would expect to see the info screen again, not the overview. Was that requested?

I agree. That's how the flow works for single certs exports. I'm not sure whether this was requested or not, but either way, both cases should behave the same imo.

@schauersbergern
Copy link
Contributor Author

Navigation from the dialogs are ok. When pressing back from the pdf overview I would expect to see the info screen again, not the overview. Was that requested?

Talked with Kerstin Jumpertz and implemented it accordingly to keep backstack on backnav

chiljamgossow
chiljamgossow reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine in general

SamuraiKek
SamuraiKek approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@schauersbergern schauersbergern merged commit 1f252d4 into release/2.25.x Jun 30, 2022
@schauersbergern schauersbergern deleted the fix/13438-screen_flow branch June 30, 2022 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chiljamgossow chiljamgossow chiljamgossow left review comments

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@SamuraiKek SamuraiKek

@chiljamgossow chiljamgossow

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.25.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schauersbergern @SamuraiKek @chiljamgossow