Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix notification spam (EXPOSUREAPP-13503) #5330

Merged
merged 2 commits into from Jul 7, 2022

Conversation

SamuraiKek
Copy link
Contributor

Spam was caused by wrong grouping of certificates where some users had slight name variations and had certificates that were eligible for booster. The previous grouping caused the dccWalletInfo to always be null, triggering a recalculation of the wallet each time the app started or the background worker was performing it's task, subsequently triggering the booster notification over and over again.

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Jul 7, 2022
@SamuraiKek SamuraiKek added this to the 2.24.x milestone Jul 7, 2022
@SamuraiKek SamuraiKek requested a review from a team July 7, 2022 10:09
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Unit Test Results - Device Release

   555 files  ±0     555 suites  ±0   5m 57s ⏱️ - 1m 2s
2 742 tests ±0  2 742 ✔️ ±0  0 💤 ±0  0 ±0 
2 791 runs  ±0  2 791 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 39fdd0b. ± Comparison against base commit 3e93feb.

Copy link
Contributor

@schauersbergern schauersbergern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like expected

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Unit Test Results - Device For Tester Release

   558 files  ±0     558 suites  ±0   6m 2s ⏱️ -43s
2 748 tests ±0  2 748 ✔️ ±0  0 💤 ±0  0 ±0 
2 797 runs  ±0  2 797 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 39fdd0b. ± Comparison against base commit 3e93feb.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Firebase Test Results

    2 files  ±0      2 suites  ±0   5m 14s ⏱️ - 16m 17s
129 tests +3  129 ✔️ +3  0 💤 ±0  0 ±0 
258 runs  +6  258 ✔️ +6  0 💤 ±0  0 ±0 

Results for commit 39fdd0b. ± Comparison against base commit 3e93feb.

@SamuraiKek SamuraiKek merged commit 21aa2fc into release/2.24.x Jul 7, 2022
@SamuraiKek SamuraiKek deleted the fix/13503-notification-spam branch July 7, 2022 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants