This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Test certificate sort order on pdf export (EXPOSUREAPP-13708) #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauersbergern
added
bug
mtwalli
reviewed
Aug 3, 2022
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/pdf/core/DccExportFilter.kt
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
mtwalli
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
The sampleCollectedAt date for test certificates also has hour and minute formatting so the instant looks like 2022-08-01T07:00:00.000Z
When this is converted to javaTime the hour and minute information gets lost resulting in 2022-08-01
As sorting also works with instant this conversion is removed to maintain hour and minute information
Testing: Scan the certificates in the ticket and check that they are sorted properly now