This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Prettify svg templates for pdf export (EXPOSUREAPP-13635) #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauersbergern
added
bug
schauersbergern
changed the title
3 tasks
|
I can still see white space between the hyphenated words and the hyphen.
|
3 tasks
@MikeMcC399 hyphens are fixed in new recent commit |
I checked by exporting a German vaccination certificate and the hyphens now look fine. 👍🏻 |
|
Kudos, SonarCloud Quality Gate passed!
|
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Testing:
Scan following EU and non EU certificates:
cwa tc gen -e wru -o --seed 10 --iss AT -s t.0.co=AT --png
cwa vc gen -e wru -o --seed 10 --iss AT -s v.0.co=AT --png
cwa rc gen -e wru -o --seed 10 --iss AT -s r.0.co=AT --png
cwa tc gen -e wru -o --seed 10 --png
cwa vc gen -e wru -o --seed 10 --png
cwa rc gen -e wru -o --seed 10 --png
Tested in Emulator, Pixel 6 and Samsung A3 where text looked good now