This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Remove all includes and data binding in layouts (EXPOSUREAPP-12794, 12795) #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rona-warn-app/cwa-app-android into feature/12795-remove-includes
|
Close button in many screens specially sub screens from Home have wrong 
|
|
Kudos, SonarCloud Quality Gate passed! |
>
@mtwalli I couldn't reproduce this issue. Are you sure it's really there? Maybe a clean/rebuild would fix it? |
mtwalli
approved these changes
Feb 3, 2023
schauersbergern
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bye bye includes & data binding.
The includes that were used in multiple places have been turned into custom views and the ones that had only one use somewhere have been implemented directly in the fragments they were used in.
Most fragments are now being properly rendered with the right content in the design preview in AS.
This change affects a lot of screens, so please test as many corners of the app as possible. The onboarding flow was heavily cluttered with includes so make sure it looks alright.
Scan certificates & tests and go through their flows.