Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

New animated icon for dark mode #848

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Jul 9, 2020

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue [HELP WANTED][README] Text / Translations  #332 for further information)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

The current version of the animated icon lacks some contrast in dark mode, this commit adds a new dark mode only icon with better contrast.

@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Jul 9, 2020
@kolyaopahle kolyaopahle requested a review from a team July 9, 2020 12:49
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pwoessner pwoessner merged commit ba27de5 into dev Jul 13, 2020
@pwoessner pwoessner deleted the fix/new-animated-icons-dark-mode branch July 13, 2020 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants