This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Dependency Injection using Hilt #876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable application & activities for hilt
…ce, DistributionService & VerificationService) - resolve cyclic dependency in SubmissionService - inline WebRequestBuilder into *Service classes
# Conflicts: # Corona-Warn-App/build.gradle # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/service/submission/SubmissionService.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/SubmitDiagnosisKeysTransactionTest.kt
|
SonarCloud Quality Gate failed.
|
|
A PR based on this one that adds DI via Dagger was merged with #1069 |
|
I understand that this PR also contains changes that add DI to various components but we need to make more granular PRs for each component to add DI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts to introduce dependency injection using hilt. So far it only covers backend connectivity. It also inlines the WebRequestBuilder into the matching Service classes.