This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
fetch & cache statistical data #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskey
commented
Jan 15, 2021
src/xcode/ENA/ENA/Source/Client/Security/CoronaWarnURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
whiskey
changed the title
This was referenced Jan 16, 2021
This was referenced Jan 17, 2021
marcussc
approved these changes
Jan 18, 2021
KaiTeuber
reviewed
Jan 18, 2021
|
|
||
| import Foundation | ||
|
|
||
| struct StatisticsMetadata: Codable { |
| self.store = store | ||
| } | ||
|
|
||
| func statistics() -> AnyPublisher<SAP_Internal_Stats_Statistics, Error> { |
There was a problem hiding this comment.
also some project MARKs missing
nickguendling
approved these changes
Jan 18, 2021
| /// - Parameters: | ||
| /// - client: The client to fetch the stats | ||
| /// - store: Used for caching | ||
| init(client: StatisticsFetching, store: Store) { |
There was a problem hiding this comment.
Suggested change
| init(client: StatisticsFetching, store: Store) { | |
| init(client: StatisticsFetching, store: StatisticsCaching) { |
| guard let lastFetch = store.statistics?.lastStatisticsFetch else { | ||
| return true | ||
| } | ||
| Log.debug("timestamp >= 300s? \(abs(Date().timeIntervalSince(lastFetch))) >= 300)", log: .appConfig) |
There was a problem hiding this comment.
Suggested change
| Log.debug("timestamp >= 300s? \(abs(Date().timeIntervalSince(lastFetch))) >= 300)", log: .appConfig) | |
| Log.debug("timestamp >= 300s? \(abs(Date().timeIntervalSince(lastFetch))) >= 300)", log: .statistics) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loads and caches statistical data. Live server fetching and testing is tbd!
Although the spec does not require a 'secure' caching of the public stats data I added them to our
Storeto be aligned with other data providers such as AddConfig. Implementing native caching for just this call would clutter the code even more.Link to Jira
Screenshots
n/a