This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Feature/4997 add datadonation to settings #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-AddDatadonationToSettings
…adonationToSettings
…adonationToSettings # Conflicts: # src/xcode/ENA/ENA/Source/Scenes/DataDonation/DataDonationViewModels/DefaultDataDonationViewModel.swift
…adonationToSettings
…ub.com/corona-warn-app/cwa-app-ios into feature/4997-AddDatadonationToSettings
fixed text formatting
Co-authored-by: Marcus Scherer <marcus@skunkbrothers.de>
fixed text formatting
…ub.com/corona-warn-app/cwa-app-ios into feature/4997-AddDatadonationToSettings
…onsent. Also, when he gives it, plain data are given.
…ub.com/corona-warn-app/cwa-app-ios into feature/4997-AddDatadonationToSettings
…atadonationToSettings # Conflicts: # src/xcode/ENA/ENA/Source/Scenes/DataDonation/DataDonationViewModels/DefaultDataDonationViewModel.swift
…ub.com/corona-warn-app/cwa-app-ios into feature/4997-AddDatadonationToSettings
Base automatically changed from
feature/4996-FORK-TASK-DataDonation-ONBOARDING
to
feature/4788-4789-4919-EPIC-PPA
February 12, 2021 15:50
…atadonationToSettings
KaiTeuber
requested review from
janetback,
SabineLoss and
tcfos
as code owners
tcfos
approved these changes
Feb 12, 2021
ArturFriesen
approved these changes
Feb 12, 2021
...de/ENA/ENA/Source/Scenes/DataDonation/DataDonationViewModels/BaseDataDonationViewModel.swift
Outdated
Show resolved
Hide resolved
...de/ENA/ENA/Source/Scenes/DataDonation/DataDonationViewModels/BaseDataDonationViewModel.swift
Outdated
Show resolved
Hide resolved
...de/ENA/ENA/Source/Scenes/DataDonation/DataDonationViewModels/BaseDataDonationViewModel.swift
Outdated
Show resolved
Hide resolved
| func save(consentGiven: Bool) | ||
| } | ||
|
|
||
| class BaseDataDonationViewModel: DataDonationViewModelProtocol { |
There was a problem hiding this comment.
Would be nice to replace this base implementation with a protocol extension.
…ub.com/corona-warn-app/cwa-app-ios into feature/4997-AddDatadonationToSettings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the datadonation work from app settings screen as well
We have different behavior and texte in here
Notice
One assert is wrong in dark mode - already requested a new version
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-4997
Screenshots