This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Remove recommendation to add labels to new issues & PRs and improve CONTRIBUTING.md #2210
Merged
marcussc
merged 12 commits into
corona-warn-app:release/2.0.x
from
Ein-Tim:fix/label-recommendation
Mar 17, 2021
Merged
Remove recommendation to add labels to new issues & PRs and improve CONTRIBUTING.md #2210
marcussc
merged 12 commits into
corona-warn-app:release/2.0.x
from
Ein-Tim:fix/label-recommendation
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshking
approved these changes
Mar 15, 2021
I would argue that this markdown is also valid for the core-contributors so it should stay in there. |
We could also add something like at point 5./6.: "[Only applicable for members of the SAP development team]" Would that be ok for you? |
@Ein-Tim Sounds good, but I would go with Core Contributors, I could be that at some point some developers that are none SAP get the rights to set those labels. |
Ein-Tim
commented
Mar 15, 2021
Create workflow
This reverts commit 325baac.
dsarkar
approved these changes
Mar 16, 2021
…/cwa-app-ios into fix/label-recommendation
marcussc
approved these changes
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the recommendation to add labels to PRs and issues in CONTRIBUTING.md because community members do not have privileges to create labels in this repository (text adapted from here)
This has been done
already.
Link to Jira
n/a