Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove recommendation to add labels to new issues & PRs and improve CONTRIBUTING.md #2210

Merged
merged 12 commits into from
Mar 17, 2021
Merged

Remove recommendation to add labels to new issues & PRs and improve CONTRIBUTING.md #2210

merged 12 commits into from
Mar 17, 2021

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Mar 13, 2021

Description

This PR removes the recommendation to add labels to PRs and issues in CONTRIBUTING.md because community members do not have privileges to create labels in this repository (text adapted from here)

This has been done

already.

Link to Jira

n/a

@Ein-Tim Ein-Tim requested a review from a team March 13, 2021 15:23
@Ein-Tim Ein-Tim changed the title Remove recommendation to create labels in new issues & PRs Remove recommendation to add labels to new issues & PRs Mar 13, 2021
@marcussc
Copy link
Contributor

I would argue that this markdown is also valid for the core-contributors so it should stay in there.

@marcussc marcussc added the admin Documentation, CI and templates label Mar 15, 2021
@marcussc marcussc added this to the v2.0.0 milestone Mar 15, 2021
@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Mar 15, 2021

@marcussc

We could also add something like at point 5./6.:

"[Only applicable for members of the SAP development team]"

Would that be ok for you?

@marcussc
Copy link
Contributor

@marcussc

We could also add something like at point 5./6.:

"[Only applicable for members of the SAP development team]"

Would that be ok for you?

@Ein-Tim Sounds good, but I would go with Core Contributors, I could be that at some point some developers that are none SAP get the rights to set those labels.

@Ein-Tim Ein-Tim marked this pull request as draft March 15, 2021 10:59
@Ein-Tim Ein-Tim marked this pull request as ready for review March 15, 2021 16:08
@whiskey
Copy link
Contributor

whiskey commented Mar 16, 2021

@marcussc @Ein-Tim
We should also annotate the "Link to Jira" as internal only. It seems most templates here are biased by the internals.

@marcussc
Copy link
Contributor

@marcussc @Ein-Tim
We should also annotate the "Link to Jira" as internal only. It seems most templates here are biased by the internals.

Maybe go with "Link to Issue" so Jira and Github Issues can be linked.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Mar 16, 2021

@marcussc @whiskey

So you mean in the PR template or a new point in the file I already touched?

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Mar 16, 2021

@marcussc @whiskey

I updated it and also added some points to reflect the current PR template. Hope that's ok.

@Ein-Tim Ein-Tim changed the title Remove recommendation to add labels to new issues & PRs Remove recommendation to add labels to new issues & PRs and improve CONTRIBUTING.md Mar 16, 2021
@marcussc marcussc enabled auto-merge March 17, 2021 08:41
@marcussc marcussc merged commit e5fc27d into corona-warn-app:release/2.0.x Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
admin Documentation, CI and templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants