This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
AppLauncher - Submission WF (Aufruf-Probleme) #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…F_(Aufruf-Probleme)
…F_(Aufruf-Probleme)
…F_(Aufruf-Probleme)
…F_(Aufruf-Probleme)
| // prevent navigation issues by falling back to overview screen | ||
| viewController.popToRootViewController(animated: false) | ||
| // dismiss all presented view controllers | ||
| viewController.view.window?.rootViewController?.dismiss(animated: false, completion: { [weak self] in | ||
| guard let self = self else { | ||
| return |
There was a problem hiding this comment.
Some Log would be nice here
There was a problem hiding this comment.
Do we need a log if the view controller was released from memory?
| @@ -186,7 +188,15 @@ class DiaryCoordinator { | |||
| self?.showDiaryDayNotesInfoScreen() | |||
| } | |||
| ) | |||
|
|
|||
| if let currentDayVC = self.viewController.viewControllers.last as? DiaryDayViewController, currentDayVC.day == day { | |||
| // prevent pushing the same day again | |||
There was a problem hiding this comment.
Perhaps add here a log, too?
ArturFriesen
approved these changes
Mar 19, 2021
…F_(Aufruf-Probleme)
naveeddotio
approved these changes
Mar 19, 2021
…F_(Aufruf-Probleme)
…F_(Aufruf-Probleme)
freshking
deleted the
fix/5518-AppLauncher_-_Submission_WF_(Aufruf-Probleme)
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dismiss all presented view controllers before doing anything
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-5518