This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Feature/6392 rat tests part 1 #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-rat-tests * origin/release/2.1.x: change of prefix fixing tests after refactoring Fix Screenshot for negative Testresult Clear ChildViewController before adding something new that shoudl replace it. moved to publisher because of reactivity changes after feedback changes for voice over adding strings changes after testing missing semi colon fix adding prefix for voice over
…-rat-tests * origin/release/2.1.x: (31 commits) add new tests log text change move a code piece to the next step prevent package download if trace warning metadata empty Bump to next Version: 2.1.0.11 Uh a rare double Bump 🤯 Bump Version prevent invoking quickactions tests in iOS < 13 + some code improvements [INTERNAL] Translation delivery: commit by LX Lab Add comments Move keys submitted to outer scope Also set positive test result shown if keys were submitted, as in previous versions (< 2.1) that value was reset on submission and we now keep it set to true until the test is deleted consider safe area Migrate to positive test result if positive test result was shown or keys submitted [INTERNAL] Translation delivery: commit by LX Lab Fix indentation Schedule warn others notifications if consent is NOT given Bump Version add missing framework imports Version Bump to 2.1.0.7 ...
marcussc
approved these changes
Apr 28, 2021
whiskey
reviewed
Apr 28, 2021
| @@ -35,7 +35,7 @@ class HomeTestResultCellModel { | |||
| @OpenCombine.Published var isActivityIndicatorHidden: Bool = false | |||
| @OpenCombine.Published var isUserInteractionEnabled: Bool = false | |||
| @OpenCombine.Published var isCellTappable: Bool = true | |||
| @OpenCombine.Published var accessibilityIdentifier: String! = AccessibilityIdentifiers.Home.submitCardButton | |||
| @OpenCombine.Published var accessibilityIdentifier: String! = "" | |||
There was a problem hiding this comment.
Would it make sense to have a generic identifier at least? So we could test for something like: XCTAssertFalse(app.cells['shouldNotExist'].exists)
There was a problem hiding this comment.
Interesting idea, I added it :)
Comment on lines
+660
to
+661
| positiveTestResultWasShown: UserDefaults.standard.string(forKey: "pcrPositiveTestResultWasShown") == "YES", | ||
| isSubmissionConsentGiven: UserDefaults.standard.string(forKey: "isPCRSubmissionConsentGiven") == "YES", |
There was a problem hiding this comment.
Would be cool to have the strings as static constants (and later stored similar to the AppStrings). This could help to keep track on all these parameters and launch arguments.
There was a problem hiding this comment.
I like that suggestion. That is something I would like to add to the refactoring/enhancement ticket for the exposure submission UI tests that we were just talking about.
naveeddotio
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds and repairs unit and UI tests.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6392