This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Fix/6843 prevent antigen qr code tampering #2574
Merged
30mar
merged 11 commits into
release/2.1.x
from
fix/6843-prevent-Antigen-QRCode-tampering
Apr 28, 2021
Merged
Fix/6843 prevent antigen qr code tampering #2574
30mar
merged 11 commits into
release/2.1.x
from
fix/6843-prevent-Antigen-QRCode-tampering
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlenkeit
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested the following scenarios:
- modified fn is rejected
- modified ln is rejected
- modified dob is rejected
- unmodified is accepted
- non-personalized with missing fields is accepted
- non-personalized with empty fields is accepted
marcussc
reviewed
Apr 28, 2021
let recomputedHashString = ENAHasher.sha256(informationString) | ||
guard recomputedHashString == testInformation.hash else { | ||
self = .rapidAntigen( .failure(.invalidTestCode(.hashMismatch))) | ||
Log.error("recomputed hash: \(recomputedHashString) Doesn't match the original hash \(testInformation.hash)", log: .qrCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice log :)
marcussc
approved these changes
Apr 28, 2021
nickguendling
approved these changes
Apr 28, 2021
…m:corona-warn-app/cwa-app-ios into fix/6843-prevent-Antigen-QRCode-tampering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-6843