This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Feature/8356 warning on behalf/8980 request #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… submission service to make it reuseable
…o ensure its up to date
naveeddotio
approved these changes
Aug 20, 2021
naveeddotio
reviewed
Aug 20, 2021
| @@ -53,6 +53,7 @@ final class ClientMock { | |||
|
|
|||
| var onGetTestResult: ((String, Bool, TestResultHandler) -> Void)? | |||
| var onSubmitCountries: ((_ payload: SubmissionPayload, _ isFake: Bool, _ completion: @escaping KeySubmissionResponse) -> Void) = { $2(.success(())) } | |||
| var onSubmitOnBehalf: ((_ payload: SubmissionPayload, _ isFake: Bool, _ completion: @escaping KeySubmissionResponse) -> Void) = { $2(.success(())) } | |||
There was a problem hiding this comment.
sounds a bit strange :D
naveeddotio
reviewed
Aug 20, 2021
| @@ -152,21 +152,19 @@ class ENAExposureSubmissionService: ExposureSubmissionService { | |||
| with: self.symptomsOnset | |||
| ) | |||
|
|
|||
| let unencryptedCheckinsEnabled = self.appConfigurationProvider.featureProvider.value(for: .unencryptedCheckinsEnabled) | |||
| let unencryptedCheckinsEnabled = AppFeatureProvider(appConfig: appConfig).value(for: .unencryptedCheckinsEnabled) | |||
There was a problem hiding this comment.
This change would not take into account the settings from the dev-menu. Please see the decorater pattern implemented to add the dev-menu functionality. Maybe we should change the pattern. Because its not obvious.
There was a problem hiding this comment.
Ah, thanks for that hint! I've now reversed that change and instead made sure that self.appConfigurationProvider.featureProvider is always up-to-date whenever the app config publisher comes back. Maybe it makes sense to get rid of the AppFeatureProvider(appConfig: appConfig) again as the publisher is now more reliable?
…e, fall back to default app config
…up-to-date app config in publisher
…ng decorators stay in effect
KaiTeuber
approved these changes
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
OnBehalfCheckinSubmissionServiceand implements the actual submission of a checkin on behalf of an attendee that doesn't use the Corona-Warn-App.Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-8980