Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Remove recommendation for creation of labels #549

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Remove recommendation for creation of labels #549

merged 2 commits into from
Mar 14, 2021

Conversation

Ein-Tim
Copy link
Contributor

@Ein-Tim Ein-Tim commented Mar 13, 2021

This PR removes the recommendation to add labels to PRs and issues in CONTRIBUTING.md because community members do not have privileges to create labels in this repository (text adapted from here)

This has been done

@dsarkar
Copy link
Member

dsarkar commented Mar 14, 2021

@Ein-Tim ok, I see. There are certain labels the community can use. Maybe it would be nice to include a sentence to use one of the available labels (bug, question, enhancement, ...) ?

Removed sencence:

  • Please apply one or more applicable labels to your issue so that all community members are able to cluster the issues better.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Mar 14, 2021

@dsarkar

Yes we could for sure go that way, I took the PR from @heinezen back in the website repo as basis, he removed the suggestion completely, so I also removed it.

Just let me know what you want 👍

@MikeMcC399
Copy link
Contributor

@dsarkar

There are certain labels the community can use. Maybe it would be nice to include a sentence to use one of the available labels (bug, question, enhancement, ...) ?

Community members do not have the privileges to add or remove labels. Labels like "Bug" are added through one of the files in ISSUE_TEMPLATE. The label depends on which issue type the user chooses when they open a new issue and it can't be changed by the user subsequently. That is only something that somebody with more privileges can do. I can't see how that works exactly because I am only a Contributor so I don't have view access to the Settings of this repository!

@Ein-Tim's PR looks good; completely removing the sentence as was already done in the other repositories.

@heinezen
Copy link
Member

@MikeMcC399 @dsarkar @Ein-Tim

Mike is correct in that non-members cannot assign or remove labels by themselves. The chosen template decides the initial labels of an issue.

Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Let's do it.

@heinezen heinezen merged commit 7eabb9f into corona-warn-app:master Mar 14, 2021
@cwa-bot cwa-bot bot moved this from ToDo to Done in [CM] cwa-documentation Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants