-
Notifications
You must be signed in to change notification settings - Fork 5
Change from #30 was not deployed #32
Comments
@dsarkar Will you be able to look at this soon? |
@Ein-Tim Will come back to you, thanks for the ping! |
@Ein-Tim It should be clear how this web content is deployed, then the question about the use of the right node version could be looked at. Perhaps the original site content was deployed manually and there is no mechanism in place to sync any updates into production? |
Yes, I guess so. However, this would contradict what is written in the README.md file. |
The README.md#updating-the-landing-page says: "Updating the landing pageAny direct commits and merged pull requests will automatically trigger follow-up actions to build and deploy the changes to e.coronawarn.app and s.coronawarn.app. The respective GitHub Actions are available in the .github/workflows directory of this repository." so yes, it seems the documentation describes the desired state, however this does not correspond to what .github/workflows actually contains. .github/workflows/build.yml is the only script to be found in .github/workflows. There is no |
It is not planned to deploy this part automatically |
Okay, thanks. So in the future, after a PR is merged, someone will deploy the change manually? Can you do this for #30 and the updated copyright year? |
The complete main branch will be deployed but it is a more complex process |
Deployment is done |
Where to find the issue
EN: https://e.coronawarn.app/en/
DE: https://e.coronawarn.app/de/
Describe the issue
It seems like the change I did in #30 was never deployed to e.coronawarn.app or s.coronawarn.app.
Suggested change
The README says:
Updating the landing page
Any direct commits and merged pull requests will automatically trigger follow-up actions to build and deploy the changes to e.coronawarn.app and s.coronawarn.app. The respective GitHub Actions are available in the .github/workflows directory of this repository.
This seems to be either out of date or was never true, as in https://github.com/corona-warn-app/cwa-event-landingpage/actions I can only find the Build Page workflow, which is only the GitHub action for the check which runs on every commit in this repo. It is, however, not the workflow deploying the changes.
So I suggest to add a workflow, similar to the one which can be found in the https://github.com/corona-warn-app/cwa-website repository, which deploys the changes merged into main here, to the PROD server.
cc @dsarkar @thomasaugsten & @christianneu
The text was updated successfully, but these errors were encountered: