Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Missing social media links for landing pages #35

Closed
MikeMcC399 opened this issue Jan 8, 2022 · 19 comments · Fixed by #40
Closed

Missing social media links for landing pages #35

MikeMcC399 opened this issue Jan 8, 2022 · 19 comments · Fixed by #40
Assignees
Labels
bug Something isn't working

Comments

@MikeMcC399
Copy link
Contributor

Where to find the issue

Describe the issue

The footers of the websites:

are no longer aligned to the footer of the website:

The footers of https://e.coronawarn.app/ and https://s.coronawarn.app/ are missing the:

  1. Link to Social Media https://www.coronawarn.app/en/community/#social-media
  2. Link to Twitter https://twitter.com/coronawarnapp
  3. Link to Instagram https://www.instagram.com/rki_fuer_euch/

Footer of https://e.coronawarn.app/ and https://s.coronawarn.app/

s coronawarn app


Footer of https://www.coronawarn.app/

coronawarn app

Suggested change

Update the footers of the websites:

to display the same as the footer of the website:

including update to the latest Copyright year.

See in particular PR corona-warn-app/cwa-website#2284 "Add social media icons and community section".

@MikeMcC399 MikeMcC399 added the bug Something isn't working label Jan 8, 2022
@dsarkar dsarkar self-assigned this Jan 8, 2022
@dsarkar
Copy link
Member

dsarkar commented Jan 8, 2022

@MikeMcC399 Thanks for pointing this out.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 8, 2022

@MikeMcC399

Do you plan to provide a PR for this? Else I could do it 🙂

@MikeMcC399
Copy link
Contributor Author

@Ein-Tim

I was not planning to provide a PR because first the issue about how this repository gets deployed needs to be solved. See your issue #32.

Unless this other issue is solved no change here in the repository would cause a change to the website.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 8, 2022

@MikeMcC399

You're right, I forgot!

Enjoy the weekend!

@MikeMcC399
Copy link
Contributor Author

@dsarkar

What are the thoughts about making this change?

I believe that the website is only displayed if the user doesn't have the app installed, so probably it will not be seen often.

It would however be more consistent to use the same footer as on the main website.

@genericmueller
Copy link

FYI: I just opened a CR for that and will bring it in production soon.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 7, 2022

@genericmueller

Thank you! So you will deploy the main branch, or?

@genericmueller
Copy link

I have a feature branch right now for testing it on all (4) ENVs but in the end deployment will be done from the main branch, sure.

@genericmueller
Copy link

@Ein-Tim Hmm, I think I mixed something up here. Sorry. I have an internal branch for our deployment, but not in this repo. This repo here is only used to be part of a Docker image, which will then be deployed by us... But for now, the latest Image represents only the footer year changes as far as I see, not more... So someone needs to accept here the latest PRs and based on that create a new Docker image. Only then am I able to apply them to the Cluster.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 7, 2022

@genericmueller Right, currently this issue from @MikeMcC399 was not addressed with a PR. Currently the last merged PR is #33 (updating the copyright year).

So what needs to be done is:

  1. Create a PR addressing this issue (@MikeMcC399 will you do this?)
  2. Create a new Docker Image
  3. You deploy the changes

FYI @dsarkar

@MikeMcC399
Copy link
Contributor Author

@genericmueller / @Ein-Tim

I suggest to look at PR corona-warn-app/cwa-website#2284 from cwa-website and pick the changes which apply here. @brifemu was the author.

I wasn't planning to submit a PR myself for this.

@genericmueller
Copy link

@Ein-Tim / @MikeMcC399
I'm just trying to figure out, who's responsible for this topic. Seems to be someone from SAP, @thomasaugsten ?

@dsarkar
Copy link
Member

dsarkar commented Feb 7, 2022

@genericmueller We can provide and merge PRs. Concerning the social media in the footer, we will try by tomorrow to have a PR ready. Anything else needs to be done?

@genericmueller
Copy link

@dsarkar Thank you! Sounds good. We can take over after the new docker image is pushed into our registry (MTR)...

@svengabr
Copy link
Member

svengabr commented Feb 8, 2022

@genericmueller I did add the footer changes to the main branch. Are you able to build the docker image and push it to the container registry or do you need someone to take care of it?

@genericmueller
Copy link

genericmueller commented Feb 8, 2022

@svengabr Theoretically, I can also build the image, but it is the responsibility of my colleagues. It must first be checked and approved. The image is built through their build pipeline and is then pushed to the registry. After that, a deployment has to be planned and our environments have to go through to production :) Unfortunately, this is the normal way even with these minor adjustments. However, I will inform the colleagues that the image can be rebuilt and tested.

@thomasaugsten
Copy link
Member

I will trigger the normal deployment process

@MikeMcC399
Copy link
Contributor Author

@svengabr
I suggest to re-open this issue until the changes are deployed.

@dsarkar dsarkar reopened this Feb 8, 2022
@MikeMcC399
Copy link
Contributor Author

Noting the comment from @thomasaugsten in #32 (comment) "Deployment is done" the social media links on the footers of:

are now updated and showing as follows:

image

So, now closing this issue as resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
6 participants